Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GW_GC1 and GW_GC2 to MOTION_SWITCH_UNSUPPORTED #632

Closed
wants to merge 2 commits into from

Conversation

nbetcher
Copy link

Add GW_GC1 and GW_GC2 to list of cameras not supporting motion (or any streaming video/audio feed at all), otherwise the log is spammed quite excessively with exceptions.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@brg468
Copy link
Collaborator

brg468 commented Sep 29, 2024

I think #607 fixes the motion switch for the OG cam.

@KyGuy2002 do you know if the telephoto cam motion can be controlled the same as the OG?

@KyGuy2002
Copy link
Contributor

afaik the telephoto and regular OG are almost identical, and anything that works with one should work with the other.

@brg468
Copy link
Collaborator

brg468 commented Sep 30, 2024

@KyGuy2002 Could you add the telephoto model ID to the list in your PR over in the other repo? Hopefully sometime soon that will get merged 🤷‍♂️

@KyGuy2002
Copy link
Contributor

Done. Thank you @nbetcher for fixing this :D

@nbetcher
Copy link
Author

nbetcher commented Oct 1, 2024

@KyGuy2002 Of course, although the final solution was fairly different, lol.

Actually, I didn't want the PR to be pushed immediately. My solution was knowingly just a hack, haha. The PR was initially a draft, but I needed to make another commit, then it got pushed automatically somehow.

Thanks for fixing it, though!

@nbetcher nbetcher closed this Oct 1, 2024
@brg468
Copy link
Collaborator

brg468 commented Oct 1, 2024

@KyGuy2002 is the motion switch unsupported on the OG cam? It looked like you had maybe fixed it in the wyzeapy PR.

@KyGuy2002
Copy link
Contributor

@brg468 Im honestly not sure. Sorry for the lack of communication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants