Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint to login page #638

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Add hint to login page #638

merged 2 commits into from
Oct 10, 2024

Conversation

brg468
Copy link
Collaborator

@brg468 brg468 commented Oct 8, 2024

Add hint about using 3rd party Oath login/password to the login page.

Discussed in #631

@brg468 brg468 linked an issue Oct 8, 2024 that may be closed by this pull request
@brg468
Copy link
Collaborator Author

brg468 commented Oct 9, 2024

I don’t remember, do we just have to modify the strings file and the translations are done automatically? I couldn’t get the translations to happen on my dev setup so I changed both..

Copy link
Owner

@SecKatie SecKatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SecKatie SecKatie merged commit 39545e2 into SecKatie:master Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Can't login via Google OAuth
2 participants