Messaging Components - Colors and Icons #605
Merged
+27
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New color: Dire Warning New icons: info, sign
|
ACK |
|
Added keyboard icons to OTF and updated components.py for 0.8.5 release:
Note: Space icon is double-width (48x24) |
|
Nice! I like the two new icons for "space" and "del" (in french they're longer too "espace" and "suppr.") as well as the "sign" icon. |
|
ACK. This button "normalization" solves a lot of future problematic with multilanguage. Let's see now how well they fit in the keyboard screen. |
|
|
ACK. I have an in-progress branch that swaps these icons in. But it'll be easier if we merge this PR first. |
|
ACK |
alvroble
added a commit
to alvroble/seedsigner
that referenced
this pull request
Jan 19, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messaging components changes as part of a larger Messaging Enhancements effort.
Link to main issue: #606
This PR adds new 2 new icons and 1 new color to components.py. The "sign" icon in psbt_screens.py has also been updated from the FontAwesome placeholder to the new icon.
New icons: info, sign
New color: Dire Warning (#FF5700)