Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI Fix] Version up all deprecated CI actions #671

Merged
merged 7 commits into from
Jan 28, 2025

Conversation

kdmukai
Copy link
Contributor

@kdmukai kdmukai commented Jan 23, 2025

Description

CI test runner is automatically failing all runs with:

This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v3.

For example: https://github.com/SeedSigner/seedsigner/actions/runs/12932802283


Changes:

  • This PR updates all CI actions that have a newer version available.
  • Per actions/upload-artifact@v4 changes, each artifact uploaded must have a distinct name.

tests.yml will run with these changes in its own CI checks for this PR; if this PR is ✅, then these changes were successful.


This pull request is categorized as a:

  • Bug fix

If you modified or added functionality/workflow, did you add new unit tests?

  • N/A

I have tested this PR on the following platforms/os:

  • N/A

@dbast
Copy link
Contributor

dbast commented Jan 23, 2025

+1

@dbast
Copy link
Contributor

dbast commented Jan 24, 2025

this PR is ready to merge and required to get other PRs green again... Github does brown-outs on old deprecated Action version by letting them fail to motivate users to upgrade.

@newtonick
Copy link
Collaborator

ACK

@newtonick newtonick merged commit 9339bc0 into SeedSigner:dev Jan 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged Not Yet Released
Development

Successfully merging this pull request may close these issues.

3 participants