Merge pull request #2257 from Sefaria/revert-2254-add-lang-toggle-he-ui

Revert "Add language toggle to sidebar in Hebrew UI"
Sefaria · Jan 16, 2025 · 276c58a · 276c58a
2 parents b9ef019 + a46c167
commit 276c58a
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 12 deletions.
diff --git a/static/css/s2.css b/static/css/s2.css
@@ -5092,18 +5092,19 @@ body .ui-autocomplete.dictionary-toc-autocomplete .ui-menu-item a.ui-state-focus
 .readerControls .readerTextToc .categoryAttribution .he {
   font-style: normal;
 }
- .leftButtons,
- .rightButtons {
+.interface-english .leftButtons,
+.interface-hebrew .rightButtons {
   display: flex;
   flex-direction: row;
+  text-align: left;
+}
+.interface-english .rightButtons,
+.interface-hebrew .leftButtons {
+  display: flex;
+  flex-direction: row;
+  text-align: right;
   align-items: center;
- }
- .leftButtons {
-  text-align: start;
- }
- .rightButtons {
-  text-align: end;
- }
+}
 /* icons need a little nudge in flipped hebrew mode */
 .interface-hebrew .rightButtons {
   margin-left: -3px;

diff --git a/static/js/ConnectionsPanelHeader.jsx b/static/js/ConnectionsPanelHeader.jsx
@@ -117,7 +117,7 @@ class ConnectionsPanelHeader extends Component {
       const toggleLang = Sefaria.util.getUrlVars()["lang2"] === "en" ? "he" : "en";
       const langUrl = Sefaria.util.replaceUrlParam("lang2", toggleLang);
       const closeUrl = Sefaria.util.removeUrlParam("with");
-      const showOneLanguage = !Sefaria._siteSettings.TORAH_SPECIFIC;
+      const showOneLanguage = !Sefaria._siteSettings.TORAH_SPECIFIC || Sefaria.interfaceLang === "hebrew";
       const toggleButton =  (showOneLanguage) ? null : (this.props.connectionsMode === 'TextList') ?
           <DropdownMenu buttonContent={<DisplaySettingsButton/>} context={ReaderPanelContext}><ReaderDisplayOptionsMenu/></DropdownMenu> :
             <LanguageToggleButton toggleLanguage={this.props.toggleLanguage} url={langUrl} />;

diff --git a/static/js/ReaderPanel.jsx b/static/js/ReaderPanel.jsx
@@ -150,8 +150,8 @@ class ReaderPanel extends Component {
       contentLangOverride = (Sefaria.interfaceLang === "english") ? "bilingual" : "hebrew";
 
     } else if ((mode === "Connections" && connectionsMode !== 'TextList') || !!menuOpen){
-      // Default bilingual to interface language
-      contentLangOverride = (originalLanguage === "bilingual") ? Sefaria.interfaceLang : originalLanguage;
+      // Always Hebrew for Hebrew interface, treat bilingual as English for English interface
+      contentLangOverride = (Sefaria.interfaceLang === "hebrew") ? "hebrew" : ((originalLanguage === "bilingual") ? "english" : originalLanguage);
     }
     return contentLangOverride;
   }