WIP: Check commit messages with Gnitpick and minor Travis-CI syntax fixes

[ottok]

No description provided.

[JoosuaKoskinen]

Does what it's supposed to do. But I did notice this at the top of Travis log.

$ python3 ./gnitpick.py
Travis-CI detected, reading git revisions from environment
fatal: ambiguous argument '': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
128
Cannot compare , is this a force push?
Gnitpick inspecting git revisions range HEAD~10..HEAD

It was not a force push and the gnitpick tests still worked the same. So the only problem is that it tested many old commit.

[ottok]

That is because of https://github.com/Seravo/gnitpick/blob/master/gnitpick.py#L174-L188
Should we change Gnitpick to check only the last 3 commits instead? Or just one?

[JoosuaKoskinen]

I think it should check 5 at the most. But why is it doing that in the first place? I did not use --force. Why wasn't the range valid?

[ottok]

You can inspect what happened by looking at the build log in https://travis-ci.org/github/Seravo/wordpress/jobs/660968721

$ python3 ./gnitpick.py
Travis-CI detected, reading git revisions from environment
fatal: ambiguous argument '': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
128
Cannot compare , is this a force push?
Gnitpick inspecting git revisions range HEAD~10..HEAD
 commit fb3cec6ef7dece5dd407f8380cd43b84ab3d14c8
 Author: Joosua Koskinen <[email protected]>
 Date:   Wed Mar 11 10:04:41 2020 +0200
 
     tEST gnitpickvim test! :) .

You can also clone the Gnitpick repo and push it around to see the output of the Travis-CI env debugger: https://github.com/Seravo/gnitpick/blob/master/.travis.yml

[elguitar]

What's the status on the review?

[ottok]

Changed to WIP status. Gnitpick needs to mature a bit more before this is ready for prime time.