Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Vagrantfile steps with wp-development-up #179

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace Vagrantfile steps with wp-development-up #179

wants to merge 2 commits into from

Conversation

JoosuaKoskinen
Copy link
Contributor

Git hook checking and certificate generation is now done in docker bootstrap so these steps are no longer needed in Vagrant file.

@JoosuaKoskinen
Remove certificate generation from Vagrantfile
d85125f 
Certificate generation is now done on Docker bootstrap.
@JoosuaKoskinen
Remove git hook check from Vagrantfile
74c4844 
The git hook check is now done on Docker bootstrap.
@JoosuaKoskinen JoosuaKoskinen requested a review from elguitar April 30, 2021 11:21
elguitar
elguitar approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@elguitar elguitar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please self-review and merge. Should be safe, since the implementation to wp-development-up is already done and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elguitar elguitar elguitar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoosuaKoskinen @elguitar