Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a field to check if it uses noteRGB instead of config.rgb or globalRGBShaders #16091

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add a field to check if it uses noteRGB instead of config.rgb or globalRGBShaders #16091

wants to merge 10 commits into from

Conversation

glowsoony
Copy link
Contributor

This is because when config.rgb is null, copying the values from globalRgbShaders doesn't account for when the Note itself changes rgb. And I added the check to allow the override incase it uses noteSplashData.r/g/b

@glowsoony glowsoony changed the title Allow Note RGB to become tempShader Add a field to check if it uses noteRGB instead of noteSplashData.r/g/b Jan 1, 2025
@glowsoony glowsoony changed the title Add a field to check if it uses noteRGB instead of noteSplashData.r/g/b Add a field to check if it uses noteRGB instead of config.rgb or globalRGBShaders Jan 1, 2025
@megalives717
Copy link

Close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glowsoony @megalives717