calculate the reward #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prince213
requested changes
Apr 9, 2024
There was a problem hiding this comment.
Move these lines up to the invitation code check block.
Comment on lines
121
to
127
| user,err:=queries.GetUserByID(nil,v.User.ID) | ||
| if err==nil{ | ||
| if user.InvCanReward == true{ | ||
| user.Reward+=1 | ||
| user.InvCanReward=false | ||
| } | ||
| } |
There was a problem hiding this comment.
Always format your code before submitting.
pkg/models/user.go
Outdated
| @@ -29,6 +29,8 @@ type User struct { | |||
| IsAdmin bool `gorm:"default:false"` | |||
| IsCommunityAdmin bool `gorm:"default:false"` | |||
| InvitationCode string | |||
| Reward int `gorm:"default:0"` | |||
| InvCanReward bool `gorm:"default:false"` | |||
There was a problem hiding this comment.
Avoid bad abbreviation. Also its purpose is not obvious by looking at the name.
AstatineAi
requested changes
Apr 9, 2024
|
|
||
|
|
||
| //若该用户通过邀请码注册 | ||
| if u.InvitationCode != ""{ |
There was a problem hiding this comment.
u.InvitationCode is the invitation code generated in the current function for the registered user, not someone else's invitation code that the new user used to register. Use the invitation_code parameter of this function.
This was
linked to
issues
Apr 9, 2024
Closed
Closed
|
@WAAutoMaton take a look at this |
WAAutoMaton
reviewed
Apr 16, 2024
There was a problem hiding this comment.
- 计算 reward 的代码不应该放在 GenerateResponse 方法内（功能和方法名字不符）。我的建议是写在
comments/Post方法内。 - 对 User 示例修改后需要调用
Save保存，否则修改不会写入数据库。 - 获得 reward 的应该是邀请该用户的用户，而不是发表评论的用户自身
- 整个修改过程应该用事务包起来，并且应该和发表评论作为同一个事务，建议是写在
comments/post.go:106中 ：
// 插入评论作为一个事务，若插入失败则回滚
err = db.Transaction(func(tx *gorm.DB) error {
...
}
WAAutoMaton
reviewed
Apr 16, 2024
There was a problem hiding this comment.
这部分代码更适合放在 register_active 的逻辑中
此外这部分也应该使用事务包起来
|
Closing due to no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calculate the reward