feat(asset-reminder): create note when reminder is sent

Shelf-nu · Jan 15, 2025 · 05765c8 · 05765c8
1 parent d39192e
commit 05765c8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/app/modules/asset-reminder/service.server.ts b/app/modules/asset-reminder/service.server.ts
@@ -56,7 +56,7 @@ export async function createAssetReminder({
         assetId,
         userId: createdById,
         type: "UPDATE",
-        content: `**${user.firstName?.trim()} ${user.lastName?.trim()}** has created a new reminder **${name}**.`,
+        content: `**${user.firstName?.trim()} ${user.lastName?.trim()}** has created a new reminder **${name.trim()}**.`,
       }),
     ]);
 

diff --git a/app/modules/asset-reminder/worker.server.ts b/app/modules/asset-reminder/worker.server.ts
@@ -8,6 +8,7 @@ import { scheduler } from "~/utils/scheduler.server";
 import { assetAlertEmailHtmlString, assetAlertEmailText } from "./emails";
 import { ASSETS_QUEUE_KEY } from "./scheduler.server";
 import type { AssetsEventType, AssetsSchedulerData } from "./scheduler.server";
+import { createNote } from "../note/service.server";
 
 const ASSET_REMINDER_INCLUDES_FOR_EMAIL = {
   teamMembers: {
@@ -96,8 +97,8 @@ const ASSET_SCHEDULER_EVENT_HANDLERS: Record<
     }
 
     /** Sending alert mails to all associated users. */
-    await Promise.all(
-      usersToSendEmail.map((user) =>
+    await Promise.all([
+      ...usersToSendEmail.map((user) =>
         sendEmail({
           subject: "Asset Reminder Notice - Shelf",
           to: user.email,
@@ -116,8 +117,14 @@ const ASSET_SCHEDULER_EVENT_HANDLERS: Record<
             isOwner: user.isOwner,
           }),
         })
-      )
-    );
+      ),
+      createNote({
+        assetId: reminder.assetId,
+        userId: reminder.createdById,
+        type: "UPDATE",
+        content: `**System** has sent **${reminder.name.trim()}** reminder.`,
+      }),
+    ]);
   },
 };