Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/basic asset reminders #1540

Open
wants to merge 85 commits into
base: main
Choose a base branch
from
Open

Feature/basic asset reminders #1540

wants to merge 85 commits into from

Conversation

rockingrohit9639
Copy link
Contributor

Issue - #1472

@rockingrohit9639
feat(asset-reminder): create UI for asset reminders
bb9038d
@rockingrohit9639
feat(asset-reminders): create schema for asset reminder
19f8db6
@rockingrohit9639
feat(asset-reminders): create schema for asset reminder
1dbb296
@rockingrohit9639
feat(asset-reminder): create action to handle creating reminder
618894f
@rockingrohit9639
Merge branch 'feature/basic-asset-reminders' of github.com:rockingroh…
eb3b73a 
…it9639/shelf.nu into feature/basic-asset-reminders
@rockingrohit9639
cMerge branch 'main' of github.com:Shelf-nu/shelf.nu into feature/bas…
68fc070 
…ic-asset-reminders
@rockingrohit9639
Merge branch 'main' of github.com:Shelf-nu/shelf.nu into feature/basi…
2fbe8a7 
…c-asset-reminders
@rockingrohit9639
feat(asset-reminder): create page to display list of reminders
1e55fd2
@rockingrohit9639
feat(asset-reminders): create frontend for edit reminder
bedc2d0
@rockingrohit9639
feat(asset-reminder): create backend to edit reminder
d467b06
@rockingrohit9639
feat(asset-reminder): create feature to delete a reminder
89e7bab
@rockingrohit9639
Merge branch 'main' of github.com:Shelf-nu/shelf.nu into feature/basi…
cf455ee 
…c-asset-reminders
@rockingrohit9639
feat(asset-reminders): add validation to select teamMember with user …
dbb2ec2 
…only
@rockingrohit9639
Merge branch 'main' of github.com:Shelf-nu/shelf.nu into feature/basi…
629758e 
…c-asset-reminders
@rockingrohit9639 rockingrohit9639 self-assigned this Dec 20, 2024
@rockingrohit9639 rockingrohit9639 linked an issue Dec 20, 2024 that may be closed by this pull request
[Feature request]: Basic Asset Reminders #1472
Open
@carlosvirreira
Copy link
Contributor

can this be tested soon? @DonKoko

@carlosvirreira
Copy link
Contributor

Reminder widget:

  • Please show the execution/sending date/time of the reminder to be sent. (They can be stacked, name, date, short description)
  • Please allow to click on the reminder name to go to the reminder tab
  • Please implement maximum characters to render on the widget to avoid situations like the one below

Screenshot 2025-01-14 at 17 10 26

Activity:

  • If we show a line item like this 'Carlos Virreira has created a new reminder ASADA'
  • It would be nice if we can have an activity log 'System' has sent ASADA reminder.
  • If you add a space in the end of your reminder name, it will show the entry with asterisks "Reminder" vs "Reminder " show differently on index.

Screenshot 2025-01-14 at 17 24 46

Reminders index:
We have on safari double scroll bars visible, for the reminder contents and also for the pagination.
Screenshot 2025-01-14 at 17 00 12

@carlosvirreira
Copy link
Contributor

Logo seems squeeshed somehow (Mac Mail).

Screenshot 2025-01-16 at 12 44 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonKoko DonKoko DonKoko requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@rockingrohit9639 rockingrohit9639

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request]: Basic Asset Reminders
3 participants
@rockingrohit9639 @carlosvirreira @DonKoko