Feature/quick actions #1573
Merged
Feature/quick actions #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockingrohit9639
requested a deployment
to
external
GitHub Actions
Waiting
DonKoko
requested changes
Jan 15, 2025
There was a problem hiding this comment.
I have slightly adjusted the design to something we like more. Its already approved by both me and Carlos so please keep that. I updated the branch already.
- On simple index, place it the most on the right
- The actions have to also be added to the advanced index
- In the advanced index we have to add something to allow to exclude certain columns from the filters, because now all columns are added on filters and we dont want a filter for the actions column.
- The
deleteandqricons are missing tooltips - For some reason the and generated from our Button component in this case are having different hover effects. They should be consistent. Can you take a look please?
rockingrohit9639
requested a deployment
to
external
GitHub Actions
Waiting
rockingrohit9639
requested a deployment
to
external
GitHub Actions
Waiting
rockingrohit9639
requested a deployment
to
external
GitHub Actions
Waiting
rockingrohit9639
requested a deployment
to
external
GitHub Actions
Waiting
rockingrohit9639
requested a deployment
to
external
GitHub Actions
Waiting
DonKoko
requested changes
Jan 16, 2025
There was a problem hiding this comment.
- We have an issue with dom validation because of button within button. We need to find a way to use
asChildon all of them with the tooltips still working.
- we also have some other dom validation issues on advanced index. I dont know if they are related to this PR but lets solve them anyways here.
rockingrohit9639
requested a deployment
to
external
GitHub Actions
Waiting
rockingrohit9639
requested a deployment
to
external
GitHub Actions
Waiting
rockingrohit9639
requested a deployment
to
external
GitHub Actions
Waiting
DonKoko
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1522