Blank Redirect Catch #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Shelob9 I'd love your review here. I don't see a downside to also catching a blank state, but would love more eyes than mine on it. |
Shelob9
reviewed
Mar 27, 2023
| @@ -109,7 +109,8 @@ function headless_mode_disable_front_end() { | |||
| ! defined( 'DOING_CRON' ) && | |||
| ! defined( 'REST_REQUEST' ) && | |||
| // prevents the case of a new user activating the plugin but not yet setting the constant. Added in 0.3.0 | |||
| HEADLESS_MODE_CLIENT_URL !== 'https://hiroy.club' && | |||
| // prevents the additional case of setting the const via an enviroment variable and forgetting to set the variable | |||
There was a problem hiding this comment.
"enviroment variable" should be "constant"
|
@Benunc This looks fine to me. Didn't test it though. If it works, merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds catch for users who set the defined variable as blank. This issue is likely to come up for users who use ElasticBean Stalk and multiple environments. You will want to redirect to different static sites depending on the environment, ie, stage site, production site. You make the change to your code:
Now say you forgot to add that variable to an environment. That will create a redirect loop that sends the header
Location: /and you might go slightly mad attempting to debug.