Dawn settings update #3683
Dawn settings update #3683
Conversation
tyleralsbury
force-pushed
the
setting-content-audit
branch
from
e657c7c to
969acea
Compare
![translation-platform[bot]](https://avatars.githubusercontent.com/in/7649?s=60&v=4){kind=small}
| "header__2": { | ||
| "content": "Announcements" | ||
| "heading_utilities": { | ||
| "content": "Utilities" |
There was a problem hiding this comment.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Utilitiesfor keysections.announcement-bar.settings.heading_utilities.contentis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
There was a problem hiding this comment.
Utilities is a heading for a group of settings like language selector and social media links that a merchant may want to toggle on to appear in their announcement bar.
There was a problem hiding this comment.
I think the comment is meant to be in the code actually. But it's okay. We can keep it as is for now I'd say.
There was a problem hiding this comment.
Oop my bad! @tyleralsbury led me astray 😃. @ludoboludo if you're familiar with how to add translation notes to the code I'd love to pair on it if you have time.
There was a problem hiding this comment.
Actually it might just be not doable at present for us as JSON doesn't support comments 🤔 Maybe something ill bring to those folks and see what they say is best 😄
| "content": "Language selector", | ||
| "info": "To add a language, go to your [language settings.](/admin/settings/languages)" | ||
| "label": "Country/region selector", | ||
| "info": "[Manage countries/regions](/admin/settings/markets)" |
There was a problem hiding this comment.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
[Manage countries/regions](/admin/settings/markets)for keysections.announcement-bar.settings.enable_country_selector.infois very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
There was a problem hiding this comment.
Country/region selector is a toggle setting that allows merchants to decide whether they would like to display this feature on their online store. The info text links to the merchants' admin settings where they can manage which countries and markets they have configured.
| "header__4": { | ||
| "content": "Language selector", | ||
| "info": "To add a language, go to your [language settings.](/admin/settings/languages)" | ||
| "label": "Country/region selector", |
There was a problem hiding this comment.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Country/region selectorfor keysections.announcement-bar.settings.enable_country_selector.labelis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
There was a problem hiding this comment.
Country/region selector is a toggle setting that allows merchants to decide whether they would like to display this feature on their online store.
| "info": "Selecting a different font can affect the speed of your store. [Learn more about system fonts.](https://help.shopify.com/manual/online-store/os/store-speed/improving-speed#fonts)" | ||
| "label": "Font" |
There was a problem hiding this comment.
Too bad we're losing the tidbits on performance/educating the users.
There was a problem hiding this comment.
This info lives inside the font picker as well, which I think is actually the better placement since the merchant would have shown shown intent to change the font first 🙂
| "header__2": { | ||
| "content": "Announcements" | ||
| "heading_utilities": { | ||
| "content": "Utilities" |
There was a problem hiding this comment.
I think the comment is meant to be in the code actually. But it's okay. We can keep it as is for now I'd say.
| "header_layout": { | ||
| "content": "Layout" | ||
| }, |
There was a problem hiding this comment.
We have many references to Layout across the file. There could be an opportunity in consolidating them like we do for sections.all.padding etc.
But it's not something that needs to happen now, it will mess with the translations we're getting back and add some more wait time.
There was a problem hiding this comment.
Yes good call - it would make sense to unify it
|
We have received a translation request but there is a question blocking translation work. Your help is needed. Please answer the following questions. Warning Replies in GitHub are not visible to translators. Use the provided "Answer here" links. 🙅♀️
Note Not your issue? Forward it to someone with more context; please don't leave it pending. 🙏 |
PR Summary:
Our new dense UI makes the online store editor look and feel more like a pro tool, but the settings labels weren't built for this new interface. This is resulting in some too-long text which wraps and makes Dawn's settings look more crowded and tougher to scan than they should be.
This is also an opportunity to bring our settings content up to date based on our newest Polaris content uplift guidelines.
Why are these changes introduced?
Fixes #0.
What approach did you take?
Other considerations
Decision log
Visual impact on existing themes
Testing steps/scenarios
Demo links
Checklist