Prepare v2.0.4 #94
Merged
Prepare v2.0.4 #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etiennebarrie
commented
Nov 20, 2023
| @@ -23,7 +23,7 @@ Gem::Specification.new do |spec| | |||
| spec.required_ruby_version = ">= 2.7" | |||
|
|
|||
| spec.files = %x(git ls-files -z).split("\x0").reject do |f| | |||
| f.match(%r{^(test)/}) | |||
| f.match(%r{^(test|spec|\.github|gemfiles)/}) | |||
There was a problem hiding this comment.
This removes a warning when unpacking the gem:
$ bundle exec rake build && gem unpack pkg/*.gem
deprecation_toolkit 2.0.3 built to pkg/deprecation_toolkit-2.0.3.gem.
WARNING: deprecation_toolkit-2.0.3 ships with a dangling symlink named gemfiles/test/deprecations pointing to missing ../../test/deprecations file. Ignoring
Unpacked gem: '/Users/etienne/src/github.com/Shopify/deprecation_toolkit/deprecation_toolkit-2.0.3'
casperisfine
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.