Merge pull request #257 from Shopify/update-shopify-taxonomy-version-…

…for-mappings Adjust Shopify taxonomy version for mappings in directory `/data/integrations`
Shopify · Aug 7, 2024 · 0506dd7 · 0506dd7
2 parents 6bce3fd + 7876a33
commit 0506dd7
Show file tree

Hide file tree

Showing 8 changed files with 284,053 additions and 7 deletions.
diff --git a/app/commands/seed_local_command.rb b/app/commands/seed_local_command.rb
@@ -13,8 +13,14 @@ class SeedLocalCommand < ApplicationCommand
     permit ["taxonomy", "integrations"]
   end
 
+  option :version do
+    desc "Distribution version"
+    short "-V"
+    long "--version string"
+  end
+
   def execute
-    params[:targets] ||= ["taxonomy", "integrations"]
+    setup_options
     frame("Seeding database") do
       import_taxonomy if params[:targets].include?("taxonomy")
       import_integrations if params[:targets].include?("integrations")
@@ -24,6 +30,11 @@ def execute
 
   private
 
+  def setup_options
+    params[:targets] ||= ["taxonomy", "integrations"]
+    params[:version] ||= sys.read_file("VERSION").strip
+  end
+
   def import_taxonomy
     frame("Importing taxonomy") do
       import_attributes_and_values
@@ -124,6 +135,8 @@ def validate_models
   # TODO: this needs to be simplified
   def mapping_rules_from(data)
     mapping_rules = []
+    shopify_taxonomy_version = "shopify/" + params[:version]
+
     data.each do |file|
       logger.debug("→ #{file}")
       from_shopify = File.basename(file, ".*").split("_")[0] == "from"
@@ -143,6 +156,18 @@ def mapping_rules_from(data)
         input_type, output_type = output_type, input_type
       end
       rules = raw_mappings["rules"]
+      input_taxonomy = if raw_mappings["input_taxonomy"] == "shopify"
+        shopify_taxonomy_version
+      else
+        raw_mappings["input_taxonomy"]
+      end
+
+      output_taxonomy = if raw_mappings["output_taxonomy"] == "shopify"
+        shopify_taxonomy_version
+      else
+        raw_mappings["output_taxonomy"]
+      end
+
       rules.each do |rule|
         input_product_category_id = rule["input"]["product_category_id"]
         input_product_category_full_name = if from_shopify
@@ -180,8 +205,8 @@ def mapping_rules_from(data)
           output_id: output_product.id,
           input_type: input_type,
           output_type: output_type,
-          input_version: raw_mappings["input_taxonomy"],
-          output_version: raw_mappings["output_taxonomy"],
+          input_version: input_taxonomy,
+          output_version: output_taxonomy,
         }
       end
     end

diff --git a/data/integrations/google/2021-09-21/mappings/from_shopify.yml b/data/integrations/google/2021-09-21/mappings/from_shopify.yml
@@ -1,5 +1,5 @@
 ---
-input_taxonomy: shopify/2024-07
+input_taxonomy: shopify/2024-10-unstable
 output_taxonomy: google/2021-09-21
 rules:
 - input:

diff --git a/data/integrations/shopify/2022-02/mappings/to_shopify.yml b/data/integrations/shopify/2022-02/mappings/to_shopify.yml
@@ -1,6 +1,6 @@
 ---
 input_taxonomy: shopify/2022-02
-output_taxonomy: shopify/2024-07
+output_taxonomy: shopify/2024-10-unstable
 rules:
 - input:
     product_category_id: 1

diff --git a/dist/en/integrations/all_mappings.json b/dist/en/integrations/all_mappings.json
@@ -2,7 +2,7 @@
   "version": "2024-10-unstable",
   "mappings": [
     {
-      "input_taxonomy": "shopify/2024-07",
+      "input_taxonomy": "shopify/2024-10-unstable",
       "output_taxonomy": "google/2021-09-21",
       "rules": [
         {
@@ -162825,7 +162825,7 @@
     },
     {
       "input_taxonomy": "shopify/2022-02",
-      "output_taxonomy": "shopify/2024-07",
+      "output_taxonomy": "shopify/2024-10-unstable",
       "rules": [
         {
           "input": {