-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Archery Categories Expanded #229
Conversation
I have signed the CLA! |
/generate_dist |
/generate_dist |
Cleary I am not having my best day finding all the typos ha. Will need to find a better way to debug locally first at some point. |
@sayscraig all good! We're still early days on how we approach all this too 😁 Give us a beat to absorb some of this (and incorporate it into a bundle of internal details we have) (cc @ricardotejedorsanz) |
@sayscraig First, thank you for your incredible contributions. We're currently working on integrating these suggestions to ensure consistency across our taxonomy. Please bear with us as we implement these changes in upcoming updates! In the meantime, do you have any links we could take a look at to support these changes? I'd also be more than happy to schedule a chat if you have a few minutes to spare 😄 |
@ricardotejedorsanz I would love to chat, that would be fantastic. What is the best way to connect? Here are a couple links as well. Filters show archery styles: https://lancasterarchery.com/collections/arrows |
Hi @sayscraig, thanks again for chatting with me the other day! Suggesting a few changes following our discussion:
Please let me know if you have any comments, and bear with us while we work on making these changes available in our next taxonomy release. |
fyi @elsom25 @tylerrowsell @KComrade53 placeholder commit with a few tweaks, pending changes to the |
@ricardotejedorsanz those updates sounds great to me. I agree with the broadhead type as well, that was a good call. |
@ricardotejedorsanz Do I need to do anything on these reviews that failed here? I have signed the CLA! so I am not sure if that fail is due to me or someone else? Just wanna make sure I'm not holding this up at all on my end. |
@sayscraig at this point I'd say its on us — selfishly I want to use this to test a few "tools" we're adding to the repo as well to see if they help with these kinds of things. It will certainly be addressed before our next version cutoff (also no idea why the CLA bot is confused all of a sudden 🥲 ) |
@elsom25 Hi just checking in since I assume we are getting close to the release of these changes. Hoping to confirm that the plan is still for this PR to get merged and released soon? |
Hi @sayscraig, sorry for the wait! We're working through pending PRs this week and are still on track to go live in the next few weeks. Thanks for your patience! 🙏 |
Moving to #391 to override merging issue. |
Updated to adjust the archery category structure and add some additional archery categories that are necessary.
At Editions.dev I spoke to someone about Shopify working with some merchants in niche industries to help expand the categories and was hoping to make contact with someone there to discuss the archery niche since we are the largest merchant in the industry. Please let me know if that is possible.