Ensure CLA check gets skipped for Argo #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsom25
approved these changes
Jan 7, 2025
elsom25
reviewed
Jan 7, 2025
danielpgross
force-pushed
the
01-07-ensure_cla_check_gets_skipped_for_argo
branch
from
7571b76 to
3808114
Compare
Merge activity
|
danielpgross
added a commit
that referenced
this pull request
Jan 8, 2025
Follow up to #520, which added comments to the definition that seem to be breaking the action altogether (example: https://github.com/Shopify/product-taxonomy/actions/runs/12668524840) This removes those comments altogether.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The automatic CLA check isn't working as desired in some cases -- the check is being enforced even though Argo is the PR author. This is happening because the check currently checks if
github.actormatches the Argo bot username, butgithub.actoris actually the user who last caused CI to be triggered, whether by commenting on the PR, pushing changes, etc.Here's a good example showing the check being enforced for an Argo PR because the triggering user was someone else.
The fix here is to directly check the PR author, instead of the event actor. This is done slightly differently depending on the event type:
pull_request_targetevent:github.event.pull_request.user.loginissue_commentevent:github.event.issue.user.loginhttps://github.com/orgs/community/discussions/25502 provides more context.