Generate dist files for new translations #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardotejedorsanz
added
taxonomy-tree-requests
There was a problem hiding this comment.
Looks like the behaviour for sorting Other isn't working correctly -- I looked at fr ("Autre") and see that it moved from the end of the file up next to others starting with "A".
I'll look into fixing this now and will post here once the fix is merged, so we can generate it again.
|
Fix is in #529 |
danielpgross
added a commit
that referenced
this pull request
Jan 16, 2025
In #528, we discovered that new localized `dist` output for `Value`s had a different sort order than existing files. The reason turned out to be that the old implementation sorted localized values according to their English names, while the new one sorted according to the localized names. This PR changes the sort logic to match the previous behaviour: sorting by the English name, regardless of the localization. It also adds tests to cover this case. I tested generating `dist` files for values with the `fr` locale and the changes were as expected.
ricardotejedorsanz
force-pushed
the
new-locales-updated-dist-files
branch
from
6cdb1a1 to
0b834d9
Compare
|
Thanks @danielpgross --pushing another commit after the fix (LGTM). |
danielpgross
approved these changes
Jan 17, 2025
ricardotejedorsanz
force-pushed
the
new-locales-updated-dist-files
branch
from
8ee02ca to
a17af17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a separate PR to generate dist files that were causing argo test to fail in #524 + quoting "ON" in polish to avoid script parsing error.