-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Other" entry as default base color to Color attribute #544
base: main
Are you sure you want to change the base?
Conversation
e88d2bd
to
4efc398
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the diff locally and it looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the diff locally and it looks good 👍
Yes, this is exactly the way the model behaves today @beefchimi. For example, we wouldn't predict [Yellow]+[Blue] for a green product. |
What's changing?
Adds
Other
to the Color attribute, which is the only standard category metafield currently lacking an escape hatch entry:This change utilizes existing localizations in our database for "Other" in non-English locales. Most languages have one term for "Other," but Czech, Norwegian Bokmål, Polish, Russian, Slovenian and Swedish have multiple.
To implement this change, we're prioritizing the most common localizations for "Other" in those languages and aligning them with the gender, number or agreement seen in other color entries like Denture base color, Hair color or Printing color:
⬆️ @aalexandreia Is this something our language experts could help us confirm?