Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Other" entry as default base color to Color attribute #544

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ricardotejedorsanz
Copy link
Contributor

What's changing?

Adds Other to the Color attribute, which is the only standard category metafield currently lacking an escape hatch entry:

image

⚠️ Notice for reviewers

This change utilizes existing localizations in our database for "Other" in non-English locales. Most languages have one term for "Other," but Czech, Norwegian Bokmål, Polish, Russian, Slovenian and Swedish have multiple.

To implement this change, we're prioritizing the most common localizations for "Other" in those languages and aligning them with the gender, number or agreement seen in other color entries like Denture base color, Hair color or Printing color:

  • Czech: "Jiné" for broader, neuter applications.
  • Norwegian Bokmål: "Annet" fits neuter, generic contexts.
  • Polish: "Inne" for uncategorized items.
  • Russian: "Другой" aligns with the masculine form used for most color names, like "Красный" (red) and "Серебряный" (silver), and is used in Denture teeth color, Hair color and Printing color.
  • Slovenian: "Drugo" for neutral contexts.
  • Swedish: "Övrigt" is appropriate for remaining items.

⬆️ @aalexandreia Is this something our language experts could help us confirm?

@ricardotejedorsanz ricardotejedorsanz added 2025-01 taxonomy-tree-requests Suggestion to improve to the taxonomy tree labels Jan 30, 2025
@beefchimi
Copy link

beefchimi commented Jan 30, 2025

My only consideration for Other as a Base color option is that, since we allow multiple color selections, is it weird to have Other combined with multiple colors?

It would be like saying:

"I have a color that is sort of blue... kind of green... but mostly yellow. Therefore I will choose Yellow, Other as my options... since its not quite blue or green".

colors

But I think I've also misunderstood the intention of this field. I guess multiple color selections do NOT represent a mix of colors into a single color - they represent a product that contains a pattern of each of those colors. Knowing this, Other makes a whole lot more sense to me.

Copy link
Collaborator

@danielpgross danielpgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the diff locally and it looks good 👍

Copy link
Collaborator

@danielpgross danielpgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the diff locally and it looks good 👍

@ricardotejedorsanz
Copy link
Contributor Author

multiple color selections do NOT represent a mix of colors into a single color - they represent a product that contains a pattern of each of those colors

Yes, this is exactly the way the model behaves today @beefchimi. For example, we wouldn't predict [Yellow]+[Blue] for a green product.

@ricardotejedorsanz
Copy link
Contributor Author

Incorporating feedback from linguists:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2025-01 taxonomy-tree-requests Suggestion to improve to the taxonomy tree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants