Unified type for shipping line #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
js-goupil
force-pushed
the
js-shipping-line-fix-2
branch
from
4fc6a64 to
64ee3cf
Compare
fatbattk
reviewed
Jan 23, 2025
| price: string; | ||
| title: string; | ||
| type: 'Custom'; | ||
| methodType: 'SHIPPING' | 'RETAIL' | undefined; |
There was a problem hiding this comment.
methodType?: 'SHIPPING' | 'RETAIL' maybe?
There was a problem hiding this comment.
have you tried doing a BaseShippingLine and then extend it for Calculated and Custom?
that should better define the shared vs properties diff.
There was a problem hiding this comment.
Have a look again?
js-goupil
force-pushed
the
js-shipping-line-fix-2
branch
from
94641ff to
20c0feb
Compare
vctrchu
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
TS on the POS side is having a hard time reconciling the idea that methodType only exists on one of the types. Let's just unified the type, and make methodType optional, in the case of custom. Much simpler interface and we can document it easily.
Solution
(Describe your solution, why this approach was chosen, and what the alternatives/impacts may be)
🎩
Checklist