Add pos.cart.update.event.observe event type
#2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProdigyXable
force-pushed
the
sam/add-event-type/pos.cart-update.event.observe
branch
from
f676039 to
0775542
Compare
ProdigyXable
requested review from
fatbattk,
js-goupil,
Alex-Palad,
NathanJolly and
vctrchu
ProdigyXable
changed the title
pos.cart update.event.observe event typepos.cart.update.event.observe event type
… `CartUpdateInput`
ProdigyXable
force-pushed
the
sam/add-event-type/pos.cart-update.event.observe
branch
from
71c2e3d to
4643bf8
Compare
Alex-Palad
approved these changes
Jan 31, 2025
js-goupil
reviewed
Jan 31, 2025
| import {BaseInput} from './BaseInput'; | ||
| import {Cart} from '../../api'; | ||
|
|
||
| export interface CartUpdateEventInput extends BaseInput { |
There was a problem hiding this comment.
Suggested change
| export interface CartUpdateEventInput extends BaseInput { | |
| export interface CartUpdatetInput extends BaseInput { |
There was a problem hiding this comment.
There is a name collision with a pre-existing CartUpdateInput related to bulk cart updates. So both cannot be ultimately exported from the package. See 4643bf8 for reference. With that context do you suggest another alternative name?
js-goupil
reviewed
Jan 31, 2025
vctrchu
reviewed
Jan 31, 2025
| @@ -52,6 +52,7 @@ Refer to the [migration guide](/docs/api/pos-ui-extensions/migrating) for more i | |||
| - Added support for cash tracking session. ${TargetLink.PosCashTrackingSessionStartObserve}, ${TargetLink.PosCashTrackingSessionCancelObserve}, ${TargetLink.PosCashTrackingSessionCompleteObserve} targets. | |||
| - Added support for the ${TargetLink.PosPrepareReceiptInject} target. | |||
| - Added support for adding custom lines to receipts. ${TargetLink.PosPrepareReceiptInject} target. | |||
| - Added support for adding custom lines to receipts. ${TargetLink.PosCartUpdateObserve} target. | |||
There was a problem hiding this comment.
Should this sentence better reflect PosCartUpdateObserve?
There was a problem hiding this comment.
😂, of course! Looks like I missed a spot from a copy/paste. Addressed in d3cdc1d.
vctrchu
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Related Issue: https://github.com/Shopify/retail-hq-store-management/issues/725
Related GSD Project: POS Channel: Add event-initiated extension targets to allow EU partners to build fiscalization compliance Extensions for POS App
This PR provides support for the
pos.cart-update.event.observeevent targetSolution
pos.cart-update.event.observepos.cart-update.event.observeChecklist