-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rearrange variables #4187
Rearrange variables #4187
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
10f06fc
to
ace0268
Compare
ace0268
to
4452be7
Compare
4452be7
to
eadc5ec
Compare
@YounixM build is failing |
37392d3
to
9c3fb11
Compare
e54c1a1
to
c168415
Compare
@YounixM every time you force-push my local branch diverges and results in conflicts making it hard to test. In general, It also makes it hard to follow what new changes have been made since the last comment. You can do regular pushes since we are going to squash them anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality wise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment
frontend/src/container/NewDashboard/DashboardVariablesSelection/DashboardVariableSelection.tsx
Outdated
Show resolved
Hide resolved
e13f652
to
7aac6b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Summary
Fixes #3802
https://www.loom.com/share/d9494bec594d4e439cb81a4c0476c06a?sid=ecae6e15-b623-4171-b0d5-fdb52bc02843
Affected Areas and Manually Tested Areas
Dashboard
Dashboard Variable Edit
Dashboard Variable Selection
Run Query
Test Run Query