Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange variables #4187

Merged
merged 12 commits into from
Dec 15, 2023
Merged

Rearrange variables #4187

merged 12 commits into from
Dec 15, 2023

Conversation

YounixM
Copy link
Member

@YounixM YounixM commented Dec 7, 2023

Summary

Fixes #3802

https://www.loom.com/share/d9494bec594d4e439cb81a4c0476c06a?sid=ecae6e15-b623-4171-b0d5-fdb52bc02843

Affected Areas and Manually Tested Areas

Dashboard
Dashboard Variable Edit
Dashboard Variable Selection
Run Query
Test Run Query

Copy link

github-actions bot commented Dec 7, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@YounixM YounixM force-pushed the rearrange-variables branch from 10f06fc to ace0268 Compare December 8, 2023 08:31
@YounixM YounixM force-pushed the rearrange-variables branch from ace0268 to 4452be7 Compare December 12, 2023 05:46
@YounixM YounixM marked this pull request as ready for review December 12, 2023 05:47
@YounixM YounixM requested a review from palashgdev as a code owner December 12, 2023 05:47
@YounixM YounixM force-pushed the rearrange-variables branch from 4452be7 to eadc5ec Compare December 12, 2023 07:03
@palashgdev
Copy link
Contributor

@YounixM build is failing

@YounixM YounixM force-pushed the rearrange-variables branch 4 times, most recently from 37392d3 to 9c3fb11 Compare December 13, 2023 11:50
@YounixM YounixM requested a review from srikanthccv December 13, 2023 13:37
@YounixM YounixM force-pushed the rearrange-variables branch from e54c1a1 to c168415 Compare December 13, 2023 13:37
@srikanthccv
Copy link
Member

@YounixM every time you force-push my local branch diverges and results in conflicts making it hard to test. In general, It also makes it hard to follow what new changes have been made since the last comment. You can do regular pushes since we are going to squash them anyway.

srikanthccv
srikanthccv previously approved these changes Dec 13, 2023
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality wise LGTM

Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment

Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@YounixM YounixM merged commit 1d014ab into develop Dec 15, 2023
8 checks passed
@srikanthccv srikanthccv deleted the rearrange-variables branch December 15, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow ordering of dashboard variables
4 participants