Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Gamerule Count Test #1639

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Remove Gamerule Count Test #1639

merged 1 commit into from
Jan 23, 2025

Conversation

sleepyyapril
Copy link
Contributor

No description provided.

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files Changes: YML Changes any yml files labels Jan 23, 2025
@SimpleStation14 SimpleStation14 changed the title Remove gamerule count test Remove Gamerule Count Test Jan 23, 2025
VMSolidus
VMSolidus approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes me wonder what Wizden does with these? Do they just not have sub gamerules anymore?

@sleepyyapril
Copy link
Contributor Author

Makes me wonder what Wizden does with these? Do they just not have sub gamerules anymore?

I think they have something else for that

@sleepyyapril
Copy link
Contributor Author

im just early merging because it's just commenting out tests

@sleepyyapril sleepyyapril merged commit fd7793e into Simple-Station:master Jan 23, 2025
13 of 14 checks passed
@sleepyyapril sleepyyapril deleted the port-more-hotfixes branch January 23, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VMSolidus VMSolidus VMSolidus approved these changes

@Remuchi Remuchi Awaiting requested review from Remuchi Remuchi is a code owner

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sleepyyapril @VMSolidus