Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markings Port Wave 1 #1658

Merged
merged 21 commits into from
Jan 26, 2025

Conversation

angelofallars
Copy link
Member

@angelofallars angelofallars commented Jan 26, 2025

Description

Added a ton of markings to the game, ported from other codebases:

Also cherry-picked space-wizards/space-station-14#30786 and space-wizards/space-station-14#30852.

I was initially going to include new Oni markings like horns, ears and tails from Adventure Time here but due to what I think is quality issues with some of them I've postponed adding them until I have the time to correct them. I gotta put out the markings I can put out now cause I know everyone's gonna want to immediately upstream merge all the other content we've added today.

Media

Pulato (from Wizden) + Iron Jaw (from Adventure Time)

image

Side Comb + Beard (Short) (all from Adventure Time)

image

Front Braids (Medium) (from Goob LRP) + Gauze Head Wrap (from Wizden)

image

IPC Wings (from SimpleStation) + Long Pompadour (from Goob LRP) + Moustache (Handlebar 2) (from Corvax)

Plasmaman Wings (from SimpleStation)

Changelog

🆑 Skubman

  • add: New hairstyles have arrived, including all Goob LRP-original hairstyles, Pulato, new facial hair and more!
  • add: Added epic IPC wings and Plasmaman wings.
  • add: Added the Iron Jaw face marking.
  • tweak: Increased the maximum number of Reptilian chest markings to 3.
  • fix: Harpy, Arachne and Lamia can no longer pick the "No Ears" marking which had no effect as they had no default ear markings.

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an RSI and removed Status: Needs Review Someone please review this labels Jan 26, 2025
Copy link
Contributor

github-actions bot commented Jan 26, 2025

RSI Diff Bot; head commit e9dc129 merging into 8eafa7a
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Mobs/Customization/hair.rsi

State Old New Status
classic_long2 Removed
classic_long3 Removed

Resources/Textures/Mobs/Customization/gauze.rsi

State Old New Status
gauze_head Added

Resources/Textures/Mobs/Customization/human_hair.rsi

State Old New Status
classiclong2 Added
classiclong3 Added
longbow Added
pulato Added
shaped Added

Resources/Textures/_ADT/Mobs/Customization/Human/custom.rsi

State Old New Status
beard-beardchin Added
beard-beardlong Added
beard-beardshort Added
beard-beardthick Added
beard-beardviking Added
beard-bristle Added
beard-mustachewithstubble Added
beard-thickbristle Added
hair-arabicgatheredhair Added
hair-classichairmale Added
hair-combedfromside Added
hair-longhair Added
hair-manbunold Added
hair-pigtailtajaran Added
hair-shavedside Added
hair-shorthaired Added
hair-womenbun Added

Resources/Textures/_ADT/Mobs/Customization/augments/headaugs.rsi

State Old New Status
iron_jaw Added

Resources/Textures/_Corvax/Mobs/Customization/human_facial_hair.rsi

State Old New Status
handlebar Added
handlebar2 Added

Resources/Textures/_Corvax/Mobs/Customization/human_hair.rsi

State Old New Status
africanpigtails Added
afropuffdouble Added
afropuffleft Added
afropuffright Added

Resources/Textures/_Goobstation/Mobs/Customization/human_hair.rsi

State Old New Status
braidedExtensions Added
cometTail Added
fantasyHair Added
flatTwistsUpdo Added
floorlengthBraid Added
floorlengthWavy Added
frizzyBraid Added
frontBraidsLong Added
frontBraidsMedium Added
frontBraidsShort Added
hairnet Added
jellyfish Added
kazuyaMishima Added
longBraids Added
longCurvy Added
longPompadour Added
mediumCurls Added
mullet Added
pelvicLengthBraid Added
plateau Added
queenBee Added
saggedMohawk Added
sharpMohawk Added
shortAndPoofy Added
shortCurls Added
shoulderLengthBraid Added
sideSpike Added
spaceLoops Added
star Added
starFro Added
styledCurls Added
unkemptScientist Added
wispy Added

Resources/Textures/_SimpleStation/Mobs/Customization/wings64x34.rsi

State Old New Status
dragon Added
fly Added
robotic Added
skeleton Added

Edit: diff updated after e9dc129

@DEATHB4DEFEAT
Copy link
Member

Have these (Simple-Station/Parkstation-Friendly-Chainsaw#25) been ported here already? would be cool

@sleepyyapril
Copy link
Contributor

this is mostly the pngs and such, its fine

@DEATHB4DEFEAT
Copy link
Member

this is mostly the pngs and such, its fine

huh?

@sleepyyapril
Copy link
Contributor

this is mostly the pngs and such, its fine

huh?

not at you, my approval

@angelofallars
Copy link
Member Author

angelofallars commented Jan 26, 2025

Have these (Simple-Station/Parkstation-Friendly-Chainsaw#25) been ported here already? would be cool

not all of them, tbh I found most of the corvax hairs (which were all straight ports from skyrat-TG btw) to not have the same quality as the hairs we have in game and/or be a duplicate of an already-existing hair but older so that's why I only kept the afropuff and african pigtails hairstyles for now

but i can deffo port some of them for markings port wave 2, most likely this for Onis :trollface:

https://github.com/Simple-Station/Parkstation-Friendly-Chainsaw/pull/25/files#diff-af69254fb99772b6fb0c9b2a35980ea8d0d2edcb04815f9b3459911c761724c0

@sleepyyapril sleepyyapril merged commit 91d14ac into Simple-Station:master Jan 26, 2025
14 of 15 checks passed
SimpleStation14 added a commit that referenced this pull request Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants