Erm.... No More Foreigner Trait Head Roles !!!!!!!!!

[SixplyDev]

Description

This PR prevents heads of staff and security members from having foreigner traits, muted trait, blindness trait, and pacifist trait (only HoS & Cap cannot be pacifist). These traits are major disabilities and actively detrimental to their departments & the rest of command staff if they have them. These traits make them unable to clearly and effectively communicate or render them unable to do a critical part of their jobs in the case of pacifist and muted.

---

TODO

• Security Department can no longer have pacifist, muted, blind, brittle bone disease, or foreigner traits.
• Head of Security can no longer have pacifist, muted, blind, brittle bone disease, or foreigner traits.
• Heads of staff can no longer have muted, blind, or foreigner traits.
• The Captain can no longer have pacifist, muted, blind, brittle bone disease, or foreigner traits.
• Head of Personnel can no longer have muted, blind, or foreigner traits.

---

Changelog

🆑 ShirouAjisai

• tweak: Security Department can no longer have pacifist, muted, blind, brittle bone disease, or foreigner traits.
• tweak: Head of Security can no longer have pacifist, muted, blind, brittle bone disease, or foreigner traits.
• tweak: Heads of staff can no longer have foreigner traits.
• tweak: The Captain can no longer have pacifist or foreigner traits.
• tweak: The Head of Personnel can no longer have foreigner traits.
• tweak: The Administrative Assistant can no longer have foreigner traits.

[sleepyyapril]

Good RP and admins fix this problem entirely (with regards to blindness and foreigner, anyway). AHelp when you encounter someone who can't do the former.

[VMSolidus]

This PR definitely needs to be significantly trimmed down. I'm also in agreement with my Maintainers that the list really should be significantly pared down.

Realistically, CMO, Mystagogue, CE, and Logistics Officer it genuinely doesn't matter if they have disabilities or are pacifists. I'm not strongly in agreement with them over discluding the Foreigner traits, since unlike Mute it outright prevents understanding your underlings. Not being fluent in the corporation's language is not the same as a disability, its a lack of a vital skill.

As one of the "Mute character mains", I can attest that you absolutely can be an excellent Captain while being mute, and it involves judicious use of the comms console and fax machine.

Of the command roles, the only one where an extremely strict no-major disabilities requirement makes sense is the Head Of Security. The HoS(and Security in general) needs to be able to pass a very stringent physical and mental aptitude test, because NT needs to be able to trust them with firearms, and be physically capable of defending corporate assets. So my request is, "both Foreigner traits" are fine to exclude from all command, but only HoS(Plus most security roles) actually needs strict ability requirements.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[VMSolidus]

You can lump in Blueshield with Security, since as a bodyguard their job description includes "Ass kicking" as a required skill. But Centcomm Rep wouldn't be lumped in because they're really just a paper pusher that might be armed.

[SixplyDev]

Ok should be ready for review now

Stale

[hivehum]

howdy, i'm a serial lurker / maint for a fork that occasionally ports from EE and i just wanted to pop in and say i'm really surprised this got merged? my understanding of the design ethos of einstein engines is to prioritize more interesting roleplay opportunities over minmaxing and this seems like... fully contradictory to that. these traits are outright disadvantageous to playing these roles so someone who opts into them is opting into a complex and interesting RP experience. like i dont frequently play on forks that i don't work on so maybe this is some kind of chronic issue i've completely missed but this really seems like something that would be better handled by downstreams...?

[SixplyDev]

howdy, i'm a serial lurker / maint for a fork that occasionally ports from EE and i just wanted to pop in and say i'm really surprised this got merged? my understanding of the design ethos of einstein engines is to prioritize more interesting roleplay opportunities over minmaxing and this seems like... fully contradictory to that. these traits are outright disadvantageous to playing these roles so someone who opts into them is opting into a complex and interesting RP experience. like i dont frequently play on forks that i don't work on so maybe this is some kind of chronic issue i've completely missed but this really seems like something that would be better handled by downstreams...?

The biggest issue I saw and the reason I did this is because people would take these traits and then drag down the rest of the team with them. I personally have no issues with someone being a mute or foreigner member of a department because I think it leads to excellent RP opportunities but I personally feel like a line has to be drawn between interesting RP and not allowing people in very important roles to drag everyone down with them because they can't handle their disabilities. It's an easy fix if you'd like to change this on your downstream fork.

[hivehum]

The biggest issue I saw and the reason I did this is because people would take these traits and then drag down the rest of the team with them. I personally have no issues with someone being a mute or foreigner member of a department because I think it leads to excellent RP opportunities but I personally feel like a line has to be drawn between interesting RP and not allowing people in very important roles to drag everyone down with them because they can't handle their disabilities. It's an easy fix I'd you'd like to change this on your downstream fork.

idk ive had such really cool and memorable experiences interacting with pacifist and blind members of security that this fully seems like something that would be better handled through ahelp rather than slapping the entire mechanic out of the hands of the playbase