Ghost Bar!!!! (From Goobstation) #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ghost bar!!!! * Update Content.Server/Goobstation/Ghostbar/Components/GhostBarSpawnComponent.cs Co-authored-by: Rank #1 Jonestown partygoer <[email protected]> * Update Content.Server/Goobstation/Ghostbar/GhostBarSystem.cs Co-authored-by: Rank #1 Jonestown partygoer <[email protected]> * Update Content.Server/Goobstation/Ghostbar/GhostBarSystem.cs Co-authored-by: Rank #1 Jonestown partygoer <[email protected]> * Rule Window * Delete on ghost + Random job selection * Fix map --------- Co-authored-by: Rank #1 Jonestown partygoer <[email protected]>
* Foam Force * make it available somewhere * add clumsyproof and nuke dev item * reorganize * oopsy files * Strap! * woopsie layering * fix grammar to rerun tests for rogue unrelated test fail. * cleanup * I eepy layer forgetti spaghetti * For real last necessary commit * Oops I broke the law! feexed * Decided to just change it to the same source as the poster source in our repo for consistency.
* No more antag ghosts :) * Oops!
* No more antag ghosts :) * Oops!
Don't wipe mind.
angelofallars
requested review from
DEATHB4DEFEAT,
sleepyyapril and
Remuchi
as code owners
github-actions
bot
added
Status: Needs Review
SimpleStation14
changed the title
|
RSI Diff Bot; head commit 69df48a merging into 2902418 Resources/Textures/Objects/Weapons/Grenades/foamdart.rsi
Resources/Textures/Objects/Weapons/Guns/Rifles/foam_rifle.rsi
Resources/Textures/Objects/Weapons/Guns/Rifles/foam_rifle_inhand_64x.rsi
|
Aidenkrz
previously requested changes
Jan 27, 2025
| [Dependency] private readonly TraitSystem _trait = default!; | ||
| // Einstein Engines end | ||
|
|
||
| private static readonly List<JobComponent> _jobComponents = new() // Einstein Engines - use JobComponent |
There was a problem hiding this comment.
Technically this is my fault but you need to add the funny lil [ValidatePrototypeID" or whatever its called here
There was a problem hiding this comment.
I dunno if that works on List of strings/proto id tho, it seems to only work on a single string/proto ID
sleepyyapril
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the Ghost Bar from Goob LRP. Upon spawn, the character's loadouts and traits will also be applied as if their job was their Ghost Bar job.
Adjusts the weights for kill objectives, re-enabling the kill objective and reducing the weight of Teach a Lesson now that there's more things to do after getting round removed.
Goobstation cherry-picked PRs:
Wizden cherry-picked PRs:
Media
Ghost Bar UI
Ghost Bar In-Game
Notice how the Ghost Bar character has loadout items in the backpack and the Skeleton Accent trait.
Changelog
🆑 Skubman