Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Additional Hair Options. #1689

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

troytroy400
Copy link

Description

Adds some new hair options pulled from RMC/CM13. Credit to @Tunguso4ka for converting the sprites to the SS14 format. PR moved from previous PR (Goob-Station/Goob-Station-MRP#74) to here by the request of @CerberusWolfie


TODO

N/A


Changelog

  • add: New Hair: Loose Bun, Shaved Bun, Buzzhawk, High & Tight, Drill Sergeant Cut, Full Buzz Cut and CIA Comb Over.

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: Localization Changes any ftl files Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an RSI and removed Status: Needs Review Someone please review this labels Jan 30, 2025
@SimpleStation14 SimpleStation14 changed the title Add additional hair options. Add Additional Hair Options. Jan 30, 2025
Copy link
Contributor

github-actions bot commented Jan 30, 2025

RSI Diff Bot; head commit bda8142 merging into 65362e5
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_Goobstation/Mobs/Customization/human_hair.rsi

State Old New Status
shortAndPoofy Modified
shortCurls Modified
shoulderLengthBraid Modified
sideSpike Modified
spaceLoops Modified
star Modified
starFro Modified
styledCurls Modified
unkemptScientist Modified
wispy Modified
braidedExtensions Removed
cometTail Removed
fantasyHair Removed
flatTwistsUpdo Removed
floorlengthBraid Removed
floorlengthWavy Removed
frizzyBraid Removed
frontBraidsLong Removed
frontBraidsMedium Removed
frontBraidsShort Removed
hairnet Removed
jellyfish Removed
kazuyaMishima Removed
longBraids Removed
longCurvy Removed
longPompadour Removed
mediumCurls Removed
mullet Removed
pelvicLengthBraid Removed
plateau Removed
queenBee Removed
saggedMohawk Removed
sharpMohawk Removed
buzzhawk Added
ciacombover Added
fullshave Added
hightight Added
loosebun Added
sergeantcut Added

Resources/Textures/_EE/Mobs/Customization/human_hair.rsi

State Old New Status
buzzhawk Added
ciacombover Added
flyboy Added
fullshave Added
hightight Added
loosebun Added
loosebunshaved Added
outwardponytail Added
overeyeponytail Added
sergeantcut Added
stubbleshave Added

Edit: diff updated after bda8142

@stellar-novas
Copy link
Contributor

stellar-novas commented Jan 31, 2025

@Tunguso4ka Do you want to be credited in the changelog and/or credited as a commit co-author?

(@ maintainers If they say yes, I'll handle merging)

Copy link
Member

@angelofallars angelofallars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got one more request. Instead of putting these in the _Goobstation namespace, put them in the _EE namespace since this is not a goobstation PR anymore.

@troytroy400
Copy link
Author

I got one more request. Instead of putting these in the _Goobstation namespace, put them in the _EE namespace since this is not a goobstation PR anymore.

I'm looking through and I noticed that the _EE namespace doesn't have a hair.rsi nor preexisting YML or FTL for adding the hair. Would I just essentially make clones of the existing files and change the pathing to be under _EE or is there something more I would need to do?

@angelofallars
Copy link
Member

I got one more request. Instead of putting these in the _Goobstation namespace, put them in the _EE namespace since this is not a goobstation PR anymore.

I'm looking through and I noticed that the _EE namespace doesn't have a hair.rsi nor preexisting YML or FTL for adding the hair. Would I just essentially make clones of the existing files and change the pathing to be under _EE or is there something more I would need to do?

Yes, you should just essentially make clones of the existing files but just with the new hairs.

@troytroy400
Copy link
Author

Yes, you should just essentially make clones of the existing files but just with the new hairs.

Alrighty, it should all be moved over to EE now. I still have the goobstation changes left over and I'm new to this so I have no idea how to remove them, is it possible to selectively merge only the EE files?

Signed-off-by: Orion <[email protected]>
@Tunguso4ka
Copy link
Contributor

@Tunguso4ka Do you want to be credited in the changelog and/or credited as a commit co-author?

no. Its okay.

@angelofallars
Copy link
Member

Yes, you should just essentially make clones of the existing files but just with the new hairs.

Alrighty, it should all be moved over to EE now. I still have the goobstation changes left over and I'm new to this so I have no idea how to remove them, is it possible to selectively merge only the EE files?

You can "reset" files/directories to their equivalent in master using this git command:
git checkout origin/master -- path/to/file
https://stackoverflow.com/a/4427783

So you'd need to run the command for Resources/Locale/en-US/_Goobstation/accessories/human-hair.ftl, Resources/Prototypes/_Goobstation/Entities/Mobs/Customization/Markings/human_hair.yml, and the directory Resources/Textures/_Goobstation/Mobs/Customization/human_hair.rsi/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants