Port Randomly Fire Dropped Weapons #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: C#
| /// The percentage chance of a given gun to accidentally discharge if violently thrown into a wall or person | ||
| /// </summary> | ||
| [DataField] | ||
| public float Reliability = 0.1f; |
There was a problem hiding this comment.
So higher reliability the worse?
There was a problem hiding this comment.
Should have a more clear name.
There was a problem hiding this comment.
I changed the name to FireOnDropChance, so that its much clearer what it does.
|
Just going to play with this in game pre-approve |
DEATHB4DEFEAT
changed the title
DEATHB4DEFEAT
approved these changes
Jun 18, 2024
| /// The percentage chance of a given gun to accidentally discharge if violently thrown into a wall or person | ||
| /// </summary> | ||
| [DataField] | ||
| public float Reliability = 0.1f; |
There was a problem hiding this comment.
Should have a more clear name.
DangerRevolution
added
Priority: 2-High
DangerRevolution
approved these changes
Jun 20, 2024
SimpleStation14
added a commit
that referenced
this pull request
Jun 20, 2024
VMSolidus
added a commit
to VMSolidus/Einstein-Engines
that referenced
this pull request
Jun 21, 2024
# Description Ports Simple-Station/Parkstation-Friendly-Chainsaw#19 I have added a new stat for firearms, the "Reliability" stat, which is a number between 0 and 1. It's used as a percentage chance for the weapon to fire itself when violently thrown into anyone. This PR differs from the original one slightly in that to get it to actually work without crashing, I set the system to listen to an event that triggers whenever the gun collides with another entity, not necessarily just the floor. This is the same event responsible for the clown's cream pie system, or for glass shards embedding in an entity. # Changelog :cl: - add: NanoTrasen has disabled the unneeded safeties on your guns- Make sure you're careful with them! - tweak: All Firearms now have a reliability stat, some are more reliable than others. The more reliable a weapon is, the less likely it is to accidentally discharge when yeeted.
VMSolidus
pushed a commit
to VMSolidus/Einstein-Engines
that referenced
this pull request
Jun 21, 2024
This was referenced Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ports Simple-Station/Parkstation-Friendly-Chainsaw#19
I have added a new stat for firearms, the "Reliability" stat, which is a number between 0 and 1. It's used as a percentage chance for the weapon to fire itself when violently thrown into anyone. This PR differs from the original one slightly in that to get it to actually work without crashing, I set the system to listen to an event that triggers whenever the gun collides with another entity, not necessarily just the floor. This is the same event responsible for the clown's cream pie system, or for glass shards embedding in an entity.
Changelog
🆑