Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR and Issue Improvements #1

Merged
merged 2 commits into from
Oct 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 16 additions & 54 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,65 +1,27 @@
# Last match in file takes precedence.

# Sorting by path instead of by who added it one day :(
# this isn't how codeowners rules work pls read the first comment instead of trying to force a sorting order
/Resources/ConfigPresets/WizardsDen/ @Chief-Engineer
/.* @DEATHB4DEFEAT

# Moony's Gargantuan List Of Things She Cares About, or MGLOTSCA for short.
# You need to add your name to these entries, not make a new one, if you care about them.
/Content.*/Toolshed/ @moonheart08
**/Toolshed/** @moonheart08
*Command.cs @moonheart08
/Content.*/Administration/ @moonheart08 @DrSmugleaf @Chief-Engineer
/Content.*/Station/ @moonheart08
/Content.*/Maps/ @moonheart08
/Content.*/GameTicking/ @moonheart08 @EmoGarbage404
/Resources/ServerInfo/ @moonheart08 @Chief-Engineer
/Resources/ServerInfo/Guidebook/ @moonheart08 @EmoGarbage404
/Resources/engineCommandPerms.yml @moonheart08 @Chief-Engineer
/Resources/clientCommandPerms.yml @moonheart08 @Chief-Engineer

/Resources/Prototypes/Maps/ @Emisse
/Content.*/ @DEATHB4DEFEAT
/Content.*/SimpleStation14/ @Pspritechologist @DEATHB4DEFEAT

/Resources/Prototypes/Body/ @DrSmugleaf # suffering
/Resources/Prototypes/Entities/Mobs/Player/ @DrSmugleaf
/Resources/Prototypes/Entities/Mobs/Species/ @DrSmugleaf
/Content.*/Body/ @DrSmugleaf
/Content.YAMLLinter @DrSmugleaf

/Content.*/Verbs/ @ElectroJr
/Content.Client/ContextMenu/ @ElectroJr
/Content.Shared/Damage/ @ElectroJr @DrSmugleaf
/Content.Shared/Containers/ItemSlot/ @ElectroJr
/Content.*/PowerCell/ @ElectroJr
/Content.*/Doors/ @ElectroJr
/Content.*/Interaction/ @ElectroJr
/Content.*/Hands/ @ElectroJr
/Content.*/Actions/ @ElectroJr
/Content.*/Explosion/ @ElectroJr
/Resources/ @DEATHB4DEFEAT

/Content.*/Anomaly/ @EmoGarbage404
/Content.*/Lathe/ @EmoGarbage404
/Content.*/Materials/ @EmoGarbage404
/Content.*/Mech/ @EmoGarbage404
/Content.*/Research/ @EmoGarbage404
/Content.*/Stack/ @EmoGarbage404
/Content.*/Xenoarchaeology/ @EmoGarbage404
/Content.*/Zombies/ @EmoGarbage404
/Resources/Prototypes/Entities/Structures/Specific/anomalies.yml @EmoGarbage404
/Resources/Prototypes/Research/ @EmoGarbage404
/Resources/Audio/SimpleStation14 @Pspritechologist @DEATHB4DEFEAT

/Content.*/Forensics/ @ficcialfaint
/Resources/Maps/ @Pspritechologist @DEATHB4DEFEAT

# SKREEEE
/Content.*.Database/ @PJB3005 @DrSmugleaf
/Content.Shared.Database/Log*.cs @PJB3005 @DrSmugleaf @Chief-Engineer
/Pow3r/ @PJB3005
/Content.Server/Power/Pow3r/ @PJB3005
/Resources/Prototypes/Maps @Pspritechologist @DEATHB4DEFEAT
/Resources/Prototypes/SimpleStation14/ @Pspritechologist @DEATHB4DEFEAT

# notafet
/Content.*/Atmos/ @Partmedia
/Content.*/Botany/ @Partmedia
/Resources/Textures/SimpleStation14/ @Pspritechologist @DEATHB4DEFEAT

#Jezi
/Content.*/Medical @Jezithyr
/Content.*/Body @Jezithyr
*.ftl @Pspritechologist @DEATHB4DEFEAT


/Scripts/ @DEATHB4DEFEAT
/Scripts/sh/ @AriaMoradi

/sloth.txt @Pspritechologist @DEATHB4DEFEAT @TemporalPrdx
28 changes: 20 additions & 8 deletions .github/ISSUE_TEMPLATE/issue_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,26 @@ assignees: ''

---

## Description
<!-- Explain your issue in detail. Issues without proper explanation are liable to be closed by maintainers. -->
# Description
<!--
Explain your issue in detail.
Issues without proper explanation are liable to be closed by maintainers.
-->

**Reproduction**
<!-- Include the steps to reproduce if applicable. -->
# Reproduction
<!--
Include the steps to reproduce if applicable.
Try to be as descriptive as possible.
-->

**Screenshots**
<!-- If applicable, add screenshots to help explain your problem. -->
# Screenshots
<!--
If applicable, add screenshots to help explain your problem.
A video of the reproduction would also be useful.
-->

**Additional context**
<!-- Add any other context about the problem here. Anything you think is related to the issue. -->
# Additional context
<!--
Add any other context about the problem here.
Anything you think is related to the issue.
-->
49 changes: 19 additions & 30 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,43 +1,32 @@
<!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline -->
<!-- The text between the arrows are comments - they will not be visible on your PR. -->
# Description

## About the PR
<!-- What did you change in this PR? -->
Description.

## Why / Balance
<!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. -->
---

## Technical details
<!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. -->
# Tasks

## Media
<!--
PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes.
Small fixes/refactors are exempt.
Any media may be used in SS14 progress reports, with clear credit given.
- [ ] Task
- [x] Completed Task

If you're unsure whether your PR will require media, ask a maintainer.
---

Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]):
-->
<details><summary><h1>Media</h1></summary>
<p>

- [ ] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase
<!-- ![Example Media Embed](https://example.com/thisimageisntreal.png) -->

## Breaking changes
<!--
List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes.
-->
</p>
</details>

**Changelog**
<!--
Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
-->
---

# Changelog

<!-- You can add an author after the `:cl:` to change the name that appears in the changelog, ex: `:cl: Death`, it will default to your GitHub display name -->

<!--
Make sure to take this Changelog template out of the comment block in order for it to show up.
:cl:
- add: Added fun!
- remove: Removed fun!
- tweak: Changed fun!
- tweak: Tweaked fun!
- fix: Fixed fun!
-->
- remove: Removed fun!
26 changes: 19 additions & 7 deletions .github/labeler.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,24 @@
"Changes: Sprites":
- '**/*.rsi/*.png'
"Changes: C#":
- "**/*.cs"

"Changes: Documentation":
- "**/*.xml"
- "**/*.md"

"Changes: Localization":
- 'Resources/Locale/**/*.ftl'

"Changes: Map":
- 'Resources/Maps/*.yml'
- 'Resources/Prototypes/Maps/*.yml'
- "Resources/Maps/**/*.yml"
- "Resources/Prototypes/Maps/**/*.yml"

"Changes: Sprite":
- "**/*.rsi/*.png"
- "**/*.rsi/*.json"

"Changes: UI":
- '**/*.xaml*'
- "**/*.xaml*"

"No C#":
- all: ["!**/*.cs"]
"Changes: YML":
- any: ["**/*.yml"]
all: ["!Resources/Maps/**/*.yml", "!Resources/Prototypes/Maps/**/*.yml"]
Loading