Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix - Economía - Formularios web - No redondear pagos Paypal con decimales #530

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Hotfix - Economía - Formularios web - No redondear pagos Paypal con decimales #530

merged 1 commit into from
Jan 21, 2025

Conversation

juanSTIC
Copy link
Collaborator

Descripción

Se modifica la conversión del importe de los pagos de Paypal para preservar los decimales.

Como probarlo

  1. Establecer la configuración PAYPAL_ID_TEST a una id válido de paypal en modo test y PAYPAL_TEST = 1
  2. Crear un formulario de captación de fondos
  3. Enviar el formulario seleccionando pago con Paypal y una cantidad que incluya decimales.
  4. De manera inmediata, verificar que el pago creado muestra los decimales correctamente
  5. Verificar que después de recibirse la confirmación del pago por parte de Paypal (puede tardar hasta 3 minutos) el pago se ha marcado como pagado y los decimales se mantienen.

@juanSTIC juanSTIC added bug Something isn't working Economía This issue or pull request already exists Formularios web labels Dec 26, 2024
@juanSTIC juanSTIC requested a review from AlbertoSTIC December 26, 2024 10:32
@juanSTIC juanSTIC self-assigned this Dec 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 26, 2024 •
edited
Loading

Actions executed at: 2025-01-21 09:11:43.

@juanSTIC juanSTIC changed the title Fix payment amount type conversion in PaymentBO.php Hotfix - Economía - Formularios web - No redondear pagos Paypal con decimales Jan 16, 2025
jordiSTIC
jordiSTIC approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@jordiSTIC jordiSTIC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(A)Probado.
Verificado el código y la funcionalidad: al recibir la respuesta de PayPal no se pierden los decimales del pago

@AlbertoSTIC AlbertoSTIC removed their request for review January 20, 2025 11:41
ainaraRT
ainaraRT approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@ainaraRT ainaraRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(A)Probado

@enricsinergia enricsinergia merged commit ddb973f into develop Jan 21, 2025
1 check passed
@enricsinergia enricsinergia deleted the bug/fixPaypalRound branch January 21, 2025 09:11
@AlbertoSTIC AlbertoSTIC mentioned this pull request Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordiSTIC jordiSTIC jordiSTIC approved these changes

@ainaraRT ainaraRT ainaraRT approved these changes

Assignees

@juanSTIC juanSTIC

Labels
bug Something isn't working Economía This issue or pull request already exists Formularios web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juanSTIC @ainaraRT @jordiSTIC @enricsinergia