Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix - General - Corrección del script que da de alta los schedulers en inglés #9

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

enricsinergia
Copy link
Collaborator

@enricsinergia enricsinergia commented Jan 3, 2024

Description

Al hacer un alata de instancia en inglés (el idioma por defecto si no se indica en la instalación del workkit lo contrario), se ha detectado que había una sentencia SQL incorrecta.
image

Pruebas

  1. Instalar el Workkit desde 0 (borrando base de datos) y comprobar que se dan de alta correctamente los schedulers.
  2. [Alternativa] Revisar el cambio de código (un ; por una ,)

@enricsinergia enricsinergia added bug Something isn't working General not urgent labels Jan 3, 2024
@enricsinergia enricsinergia self-assigned this Jan 3, 2024
Copy link

github-actions bot commented Jan 3, 2024

Actions executed at: 2024-01-18 09:16:04.

ainaraRT
ainaraRT previously approved these changes Jan 11, 2024
Copy link
Collaborator

@ainaraRT ainaraRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(A)Probado instalando desde cero el Workkit y borrando base de datos

Copy link
Collaborator

@ManuSinergiaCRM ManuSinergiaCRM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En el mismo fichero, ocurre lo mismo en la línea 68

Y en el mismo fichero del resto de idiomas también de dan los dos errores:

  • SticInstall/sql/ca/Schedulers.sql
  • SticInstall/sql/es/Schedulers.sql
  • SticInstall/sql/gl/Schedulers.sql

Además, estoy comprobando que los registros de la línea 42 y 69 existen en las instancias. En unos minutos informo de los resultados

@ManuSinergiaCRM
Copy link
Collaborator

Confirmo que las instancias de las entidades tienen los registros de las líneas 42 y 69. La única instancia que no los tiene es la de Jordi.

Copy link
Collaborator

@ManuSinergiaCRM ManuSinergiaCRM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(A)probado

@AlbertoSTIC AlbertoSTIC changed the title Hotfix - General - Corrección del script que da de alta los schedulers en inglés Improvement - General - Corrección del script que da de alta los schedulers en inglés Jan 18, 2024
@AlbertoSTIC AlbertoSTIC changed the title Improvement - General - Corrección del script que da de alta los schedulers en inglés Hotfix - General - Corrección del script que da de alta los schedulers en inglés Jan 18, 2024
@enricsinergia enricsinergia requested review from AlbertoSTIC and removed request for ainaraRT January 18, 2024 09:12
Copy link
Collaborator

@AlbertoSTIC AlbertoSTIC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(A)probado.

@AlbertoSTIC AlbertoSTIC merged commit e9eed7e into develop Jan 18, 2024
1 check passed
@AlbertoSTIC AlbertoSTIC deleted the bug/EnglishSchedulers branch January 18, 2024 09:15
AlbertoSTIC pushed a commit that referenced this pull request Jan 18, 2024
jordiSTIC pushed a commit that referenced this pull request Jan 23, 2024
PaulaaSTIC pushed a commit that referenced this pull request Feb 26, 2024
# This is the 1st commit message:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #2:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #3:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #4:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #5:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #6:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #7:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #8:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #9:

Fix salesagility#10364 - Adding now option in Datetime fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working General not urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants