Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/Update - Future Release #17

Merged
merged 10 commits into from
Dec 5, 2024
Merged

Dev/Update - Future Release #17

merged 10 commits into from
Dec 5, 2024

Conversation

ShaneBeee
Copy link
Collaborator

@ShaneBeee ShaneBeee commented Dec 2, 2024

This PR is showing what is happening in the next release:

Temp changelog:

REMOVED:

  • Particle Data TargetColor Type/Function have been removed (Bukkit removed the class)
    Since SkBee only supports the latest release of each major MC version, and since this was 1.21.3 ONLY, theres no need to do any crazy reflection to make this work. (See Trail below)

ADDED:

  • Added preliminary 1.21.4 support (light testing has been done, but everything seems to work as intended)
  • Particle Data Trail Type/Function have been added (a replacement for TargetColor, but also contains a timespan)

CHANGED:

  • Comparators - only auto-register comparators if they don't exist
  • Changed some ClassInfos to only register if they're not registered already by Skript/Addon (Registering Fixes #14 thanks @JakeGBLP )

@ShaneBeee ShaneBeee added the future A future feature/release. label Dec 2, 2024
JakeGBLP and others added 8 commits December 2, 2024 10:44
…egistered (#14)

* Added checks to avoid registering ClassInfos when another plugin already does so.

* Merged if statements N1

Co-authored-by: Nathan <[email protected]>

* Added line breaks between if blocks

* Merged if statements

* Merged if statements and removed extra lines

* Removed duplicate condition

* fix some run-away brackets

---------

Co-authored-by: Nathan <[email protected]>
Co-authored-by: ShaneBeee <[email protected]>
- remove TargetColor type/function (bukkit just removed the class)
- add Trail type/function (bukkit's replacement)
- this is to make sure the syntaxes dont cause issue
- This ensures SkBee tests on the latest version of Skript
- this is to make sure if there are errors we will know
@ShaneBeee ShaneBeee merged commit 5e6c5ef into master Dec 5, 2024
4 checks passed
@ShaneBeee ShaneBeee deleted the dev/update branch December 5, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future A future feature/release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants