Fix tag lookup for "skript" and "paper" #7450
Merged
+38
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a regression test
Efnilite
requested changes
Jan 16, 2025
src/test/skript/tests/regressions/7449-tag lookup only does minecraft.sk
Outdated
Show resolved
Hide resolved
Efnilite
added
the
bug
…necraft.sk Co-authored-by: Efnilite <[email protected]>
- Remove lookup if namespace is provided
…to bug/7449-tag_namespace_check
- Cleanup lookup code - thanks sovde for explaining in further detail/provide literal code.
Efnilite
reviewed
Jan 28, 2025
src/main/java/org/skriptlang/skript/bukkit/tags/elements/ExprTag.java
Outdated
Show resolved
Hide resolved
- Revert back to package-private
Efnilite
approved these changes
Jan 29, 2025
sovdeeth
approved these changes
Feb 1, 2025
APickledWalrus
added
the
patch-ready
APickledWalrus
approved these changes
Feb 1, 2025
src/main/java/org/skriptlang/skript/bukkit/tags/elements/ExprTag.java
Outdated
Show resolved
Hide resolved
…ag.java Co-authored-by: Patrick Miller <[email protected]>
src/main/java/org/skriptlang/skript/bukkit/tags/elements/ExprTag.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/tags/elements/ExprTag.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/tags/elements/ExprTag.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the tag lookup for the
ExprTagclass. This should now makehelmetscheckminecraft:helmetsandpaper:helmets(ending at paper)If someone has a suggestion for how test should be done I'm willing to here, this will break if minecraft ever adds
minecraft:helmetstag, which somehow they never have.NOTE:
This PR is currently targeting master to limit the amount of file changes until the team merges master into dev/patchTarget Minecraft Versions: any
Requirements: none
Related Issues: #7449