Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable regex based highlighting for runtime errors #7526

Merged
merged 2 commits into from
Feb 1, 2025
Merged

Enable regex based highlighting for runtime errors #7526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c533546
Enable regex based highlighting for runtime errors
sovdeeth Jan 25, 2025
aff68dc
Merge branch 'dev/patch' into fix/regex-highlight-runtime-errors
APickledWalrus Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/skriptlang/skript/bukkit/log/runtime/BukkitRuntimeErrorConsumer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public void printError(@NotNull RuntimeError error) {
ErrorSource source = error.source();
String code = source.lineText();
if (error.toHighlight() != null && !error.toHighlight().isEmpty())
code = code.replace("§", "&").replace(error.toHighlight(), "§f§n" + error.toHighlight() + "§7");
code = code.replace("§", "&").replaceFirst(error.toHighlight(), "§f§n$0§7");

SkriptLogger.sendFormatted(Bukkit.getConsoleSender(),
String.format(skriptInfo, source.script(), source.syntaxName(), source.syntaxType()) +
Expand Down
1 change: 1 addition & 0 deletions src/main/java/org/skriptlang/skript/log/runtime/RuntimeError.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,6 @@
* @param source The source of the error
* @param error The message to display as the error
* @param toHighlight Optionally, the text within the emitting line to highlight.
* This should be treated as a regex pattern and will highlight the first match it finds.
*/
public record RuntimeError(Level level, ErrorSource source, String error, @Nullable String toHighlight) { }