-
-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a LootTable Serializer #7528
Add a LootTable Serializer #7528
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor little things
src/main/java/org/skriptlang/skript/bukkit/loottables/LootTableModule.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/loottables/LootTableModule.java
Outdated
Show resolved
Hide resolved
Do you think it's alright to save these when the available loottables could be changing between variables loads? Since it's only saving the key, it's reliant on the server environement not changing between saving and loading. If a data pack is removed, it could cause these variables to fail to load. |
In all fairness, the same could be said for anything that has a RegistryClassInfo, as well as ItemType. |
Good point, it's the same for blocks and removing worlds too. Just wanted to confirm there wasn't a better way. |
Description
This PR adds a LootTable serializer.
Target Minecraft Versions: any
Requirements: none
Related Issues: none