Update ExprNoDamageTicks Allowing Timespans #7554
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAbsolutionism
changed the title
Requested
ShaneBeee
suggested changes
Jan 30, 2025
src/main/java/ch/njol/skript/expressions/ExprNoDamageTicks.java
Outdated
Show resolved
Hide resolved
Efnilite
requested changes
Jan 30, 2025
src/main/java/ch/njol/skript/expressions/ExprNoDamageTicks.java
Outdated
Show resolved
Hide resolved
Efnilite
added
the
enhancement
TheAbsolutionism
requested review from
APickledWalrus,
ShaneBeee and
Efnilite
Efnilite
requested changes
Jan 31, 2025
src/main/java/ch/njol/skript/expressions/ExprNoDamageTimespan.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprNoDamageTimespan.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprNoDamageTimespan.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprNoDamageTimespan.java
Outdated
Show resolved
Hide resolved
src/test/skript/tests/syntaxes/expressions/ExprNoDamageTicks.sk
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprNoDamageTicks.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to update
ExprNoDamageTicksallowing users to get the value as a timespan and use a timespan to set the value.To avoid breaking changes from changing the
getto only return timespan, I added a new pattern that lets users specifically get the timespan.Target Minecraft Versions: any
Requirements: none
Related Issues: #5197