Fix Date Serialization #7570
Merged
Fix Date Serialization #7570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
added
bug
sovdeeth
approved these changes
Feb 1, 2025
erenkarakal
approved these changes
Feb 1, 2025
APickledWalrus
added
the
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the date serialization issue on 2.10. Before 2.9, dates were serialized with the primitive field being represented as
timestamp(the name of the old field). However, when serialization was updated in 2.10, the serializer was created using "time" as the Fields name, which is why old variables could not be deserialized.I resolve this issue by changing the name back to
timestampand adding a compatibility check for thetimefield name.Target Minecraft Versions: any
Requirements: none
Related Issues: