Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ratings): replace slider UI with new rater component [SCHOOL-17] #564

Draft
wants to merge 17 commits into
base: feat/ratings-backend
Choose a base branch
from
Draft

feat(ratings): replace slider UI with new rater component [SCHOOL-17] #564

wants to merge 17 commits into from

Conversation

ryon
Copy link
Contributor

@ryon ryon commented Dec 8, 2020 •
edited by themightychris
Loading

Closes: SCHOOL-17, #531

  • In this first draft, the Rater is implemented in SlateDemonstrationsTeacher on the Slate.cbl.field.ratings.StudentCompetency window
  • Nothing is wired up yet
  • Also adds a "Remove" button to the competency

Screen Shot 2020-12-08 at 12 47 03 PM

@github-actions github-actions bot temporarily deployed to pr-564 December 8, 2020 17:48 Inactive
@ryon ryon changed the title SCHOOL-5 Add ratings Rater component to replace Slider SCHOOL-17 Add ratings Rater component to replace Slider Dec 8, 2020
@github-actions github-actions bot temporarily deployed to pr-564 December 9, 2020 03:08 Inactive
@themightychris themightychris force-pushed the features/new-ratings-slider branch from bb3a5f5 to 6e40fea Compare December 22, 2020 02:26
@github-actions github-actions bot temporarily deployed to pr-564 December 22, 2020 02:27 Inactive
@ryon ryon force-pushed the features/new-ratings-slider branch from 6e40fea to d14c444 Compare December 22, 2020 03:54
@github-actions github-actions bot temporarily deployed to pr-564 December 22, 2020 03:55 Inactive
@github-actions github-actions bot temporarily deployed to pr-564 December 22, 2020 03:58 Inactive
@themightychris themightychris changed the title SCHOOL-17 Add ratings Rater component to replace Slider Add ratings Rater component to replace Slider [SCHOOL-17] Dec 22, 2020
@github-actions github-actions bot temporarily deployed to pr-564 December 22, 2020 17:58 Inactive
@github-actions github-actions bot temporarily deployed to pr-564 December 22, 2020 18:22 Inactive
@github-actions github-actions bot temporarily deployed to pr-564 December 22, 2020 19:40 Inactive
@github-actions github-actions bot temporarily deployed to pr-564 December 22, 2020 19:44 Inactive
@github-actions github-actions bot temporarily deployed to pr-564 December 23, 2020 01:04 Inactive
@themightychris themightychris force-pushed the features/new-ratings-slider branch from 11da99c to c9a6358 Compare December 27, 2020 04:44
@github-actions github-actions bot temporarily deployed to pr-564 December 27, 2020 04:45 Inactive
@github-actions github-actions bot temporarily deployed to pr-564 January 7, 2021 17:31 Inactive
@themightychris themightychris force-pushed the features/new-ratings-slider branch from c9a6358 to cdbf0e9 Compare January 19, 2021 03:26
@github-actions github-actions bot temporarily deployed to pr-564 January 19, 2021 03:27 Destroyed
@github-actions github-actions bot temporarily deployed to pr-564 January 19, 2021 18:20 Destroyed
@github-actions github-actions bot temporarily deployed to pr-564 January 20, 2021 23:24 Destroyed
@themightychris themightychris force-pushed the features/new-ratings-slider branch from 5dbc68e to 78cb635 Compare February 15, 2021 15:26
@github-actions github-actions bot temporarily deployed to pr-564 February 15, 2021 15:26 Destroyed
@github-actions github-actions bot temporarily deployed to pr-564 February 16, 2021 17:38 Destroyed
@github-actions github-actions bot temporarily deployed to pr-564 March 14, 2021 19:57 Destroyed
@github-actions github-actions bot temporarily deployed to pr-564 March 14, 2021 20:41 Destroyed
@themightychris themightychris force-pushed the features/new-ratings-slider branch from 8ff1740 to 6b7303c Compare March 28, 2021 22:39
@github-actions github-actions bot temporarily deployed to pr-564 March 28, 2021 22:40 Destroyed
@themightychris themightychris force-pushed the features/new-ratings-slider branch from 6b7303c to 9c5202e Compare March 30, 2021 17:50
@github-actions github-actions bot temporarily deployed to pr-564 March 30, 2021 17:51 Destroyed
@themightychris themightychris force-pushed the features/new-ratings-slider branch from 5a4bd65 to 1d4a21b Compare August 21, 2022 12:59
@github-actions github-actions bot temporarily deployed to pr-564 August 21, 2022 13:00 Destroyed
@themightychris themightychris force-pushed the features/new-ratings-slider branch from 1d4a21b to dd6d38f Compare August 21, 2022 16:03
@github-actions github-actions bot temporarily deployed to pr-564 August 21, 2022 16:04 Destroyed
@themightychris themightychris force-pushed the features/new-ratings-slider branch from dd6d38f to 6725b9f Compare August 22, 2022 14:55
@github-actions github-actions bot temporarily deployed to pr-564 August 22, 2022 14:56 Destroyed
@themightychris themightychris force-pushed the features/new-ratings-slider branch from 6725b9f to e792119 Compare December 14, 2022 03:56
@themightychris themightychris changed the title Add ratings Rater component to replace Slider [SCHOOL-17] feat(ratings): replace slider UI with new rater component [SCHOOL-17] Dec 14, 2022
@themightychris themightychris changed the base branch from develop to feat/ratings-backend January 2, 2023 02:56
@themightychris themightychris force-pushed the features/new-ratings-slider branch from e792119 to cfcc6c7 Compare January 2, 2023 02:56
ryon and others added 17 commits January 31, 2023 13:47
@ryon @themightychris
feat: add first-pass draft of ratings Rater to replace Slider
a0ed991
@ryon @themightychris
feat: improve design of new skill rater component
1345159
@ryon @themightychris
chore: remove rebase artifacts
7500cf5
@themightychris
fix: add missing requires
aaed76e
@ryon @themightychris
fix: add missing requires for Rater component
9e7894e
@themightychris
chore: remove duplicate requires
8e4439e
@themightychris
fix: add missing requires
2c4a4f9
@ryon @themightychris
feat: tweak colors on rater buttons
ff0d3ec
@themightychris
feat(rater): populate skill labels
935b42d
@themightychris
fix(rater): handle cleaning up new raters
f16366b
@themightychris
feat(rater): dynamically populate rating options
87a12e6
@themightychris
fix(rater): use inclusive range for min/max rating
d0b589c
@themightychris
refactor(rater): pass entire DemonstrationSkill object as rater value
10b3a0a
@themightychris
feat(rater): enable toggling between menu values and primary values
a36906e
@themightychris
docs: begin article on customizing CBL ratings
9f69cd4
@themightychris
feat(rater): show menu value in menu button
88eac5b
@themightychris
feat(demos): add missing/dnm demoskill subtypes
0fbdc1a
@themightychris themightychris force-pushed the features/new-ratings-slider branch from cfcc6c7 to 0fbdc1a Compare January 31, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryon @themightychris