-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend): adding file generator precheck with testing #64
Conversation
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - **New Features** - Introduced a new template for React applications using TypeScript and Vite, including essential setup files. - Added a main HTML entry point for the application. - Configured ESLint for improved code quality and best practices in TypeScript and React environments. - **Documentation** - Added a README file outlining setup instructions and recommended configurations for the template. - **Configuration** - New TypeScript and Vite configuration files created to optimize the development environment. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Caution Review failedThe pull request is closed. Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
backend/src/build-system/__tests__/test-file-create.spec.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-prettier". (The package "eslint-plugin-prettier" was not found when loaded as a Node module from the directory "/backend".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
The plugin "eslint-plugin-prettier" was referenced from the config file in "backend/.eslintrc.js". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. WalkthroughThis pull request involves the deletion of three documentation files related to a Spotify-like music web application, which included a datamap structure, database requirements, and file structure overview. Additionally, it introduces several new and modified test suites and handlers that enhance file generation, virtual directory management, and UX sitemap processing. The changes also include the addition of utility methods for JSON extraction and improved logging practices across various components, thereby refining the overall architecture and functionality of the build system. Changes
Possibly related PRs
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (17)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…com/Sma1lboy/GeneratorAI into feat(backend)Test_and_file_generate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM.
Also Adding TODO with name eg. // TODO(allen):
to help us getting back context later if there are some optimization we can do
backend/src/build-system/node/file-generate/Virtual-Directory.ts
Outdated
Show resolved
Hide resolved
backend/src/build-system/node/file-generate/Virtual-Directory.ts
Outdated
Show resolved
Hide resolved
private readonly logger: Logger = new Logger('FileArchGenerateHandler'); | ||
|
||
// TODO: adding page by page analysis | ||
async run(context: BuilderContext, ...args: any[]): Promise<BuildResult> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why dont we keep muti args?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary by CodeRabbit
New Features
FileGeneratorHandler
class for generating files based on JSON data from Markdown.VirtualDirectory
class to simulate a virtual file system structure.BuilderContext
class with virtual directory management capabilities.Improvements
Tests
FileGeneratorHandler
andVirtualDirectory
functionalities.