-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(backend): refactor context part #72
Conversation
Caution Review failedThe pull request is closed. Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
backend/src/build-system/__tests__/test-file-create.spec.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-prettier". (The package "eslint-plugin-prettier" was not found when loaded as a Node module from the directory "/backend".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
The plugin "eslint-plugin-prettier" was referenced from the config file in "backend/.eslintrc.js". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. WalkthroughThis pull request introduces a comprehensive refactoring of the build system's architecture, focusing on enhancing type safety, improving context management, and streamlining handler implementations. The changes span multiple files across the build system, with key modifications including simplifying node identifiers, updating method signatures to remove variadic arguments, and introducing more explicit context data retrieval methods. The refactoring aims to create a more consistent and type-safe approach to handling build sequences, with a particular emphasis on how data is passed between different stages of the build process. Changes
Sequence DiagramsequenceDiagram
participant Context as BuilderContext
participant Executor as BuildSequenceExecutor
participant Handler as BuildHandler
Context->>Context: Initialize globalContext
Context->>Context: Set global/node data
Executor->>Context: Request node execution
Context->>Handler: Run handler
Handler->>Context: Store result in nodeData
Executor-->>Context: Update execution state
Possibly related PRs
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (21)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…actor context storage
…from operation IDs
…etNodeData method
…h projectPart option
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Documentation
Refactor
Style