-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding detail log in each handler #90
Conversation
Caution Review failedThe pull request is closed. Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
backend/src/build-system/__tests__/test.fullstack-gen.spec.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-prettier". (The package "eslint-plugin-prettier" was not found when loaded as a Node module from the directory "/backend".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
The plugin "eslint-plugin-prettier" was referenced from the config file in "backend/.eslintrc.js". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. WalkthroughThis pull request introduces significant changes to the backend build system, focusing on enhancing chat-based interactions across various handlers. The primary modification is the introduction of a new Changes
Sequence DiagramsequenceDiagram
participant Handler
participant ChatSyncWithClocker
participant ModelProvider
participant BuildMonitor
Handler->>ChatSyncWithClocker: Invoke with context, messages
ChatSyncWithClocker->>ModelProvider: Request chat sync
ModelProvider-->>ChatSyncWithClocker: Return model response
ChatSyncWithClocker->>BuildMonitor: Record time and details
ChatSyncWithClocker-->>Handler: Return model response
Possibly related PRs
Suggested Labels
Suggested Reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (18)
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
messages: [{ content: backendCodePrompt, role: 'system' }], | ||
}); | ||
|
||
const modelResponse = await BuildMonitor.timeRecorder( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz don't do that, just clock after
const modelResponse = await context.model.chatSync({
model: 'gpt-4o-mini',
messages: [{ content: backendCodePrompt, role: 'system' }],
});
context.monitor.record(inputPrompt, response, this.id, title
I don't think it's hard to avoid Interdependence, it's very clearly BuildMonitor and ModelProvider are same level class
….com/Sma1lboy/codefox into feat-adding-detail-logger-in-monitor
Summary by CodeRabbit
Release Notes
New Dependency
gpt-3-encoder
package to project dependenciesBuild System Enhancements
chatSyncWithClocker
utility for improved model interactionMonitoring Improvements
Code Generation
Performance