session_lock: Add accessor for ExtSessionLockV1 to SessionLocker
#1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compositor can store this, and test if the object is still valid with `DisplayHandle::get_client`. This way the compositor can allow another session lock to be created if the previous client crashed and failed to unlock.
Drakulix
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compositor can store this, and test if the object is still valid with
DisplayHandle::get_client. This way the compositor can allow another session lock to be created if the previous client crashed and failed to unlock.Maybe there could be a better API to help with this, but I'm not sure how.
pop-os/cosmic-comp#205 demonstrates how this can be handled.