Fix for Potential memory leak in class ServiceArgumentParser's Constr… (

osquery#8368)
Smjert · Jul 6, 2024 · 02a883d · 02a883d
1 parent a79dfd5
commit 02a883d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/osquery/main/windows/main.cpp b/osquery/main/windows/main.cpp
@@ -89,6 +89,7 @@ class ServiceArgumentParser {
       LPWSTR* wargv = ::CommandLineToArgvW(::GetCommandLineW(), &wargc);
 
       if (wargv != nullptr) {
+        owns_argv_ptrs_ = true;
         for (int i = 0; i < wargc; i++) {
           LPSTR arg = toMBString(wargv[i]);
 
@@ -99,7 +100,6 @@ class ServiceArgumentParser {
           }
           args_.push_back(arg);
         }
-        owns_argv_ptrs_ = true;
         ::LocalFree(wargv);
       }
     }