Add netstandard2.0 support #9
Conversation
|
Could you fix tests for |
|
Hi there, the tests already pass on windows. I see now that the github script runs the tests on ubuntu which fails trying to run tests for net48 for obvious reasons. I am not sure how to fix this off the top of my head, but I can have a look. |
|
For net48 on Ubuntu and macOS I expect installing Mono should work on those platforms. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9 +/- ##
==========================================
+ Coverage 81.72% 81.77% +0.05%
==========================================
Files 23 23
Lines 2687 2689 +2
Branches 365 370 +5
==========================================
+ Hits 2196 2199 +3
+ Misses 480 479 -1
Partials 11 11 ☔ View full report in Codecov by Sentry. |
|
I thought it would be a better idea to split out a separate github actions step which only tests the net48 target on the windows-latest image, but because of the change to the script, if you agree with the change you will need to approve the workflow for me to verify it works. |
|
Yeah thats fine too, mono tests can be added after the fact anyways |
|
Is there anything I need to do for the failed codecov check? |
|
Thanks for your contribution! Nuget releases have to be pushed manually so expect one within the next 24 hours. |
|
Sorry, might be a couple of days until I can push a release |
It is trivial to add netstandard2.0 support with a few small changes. This allows the usage of the library in the .net full framework. I also fixed a bug in the MatchingBytesToLeft method, where vector extensions were not being used on net6 and up.