chore: TU fix

SocialGouv · Jan 8, 2025 · e903723 · e903723
1 parent e9cd917
commit e903723
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 30 deletions.
diff --git a/packages/code-du-travail-frontend/app/contribution/[slug]/page.tsx b/packages/code-du-travail-frontend/app/contribution/[slug]/page.tsx
@@ -18,7 +18,7 @@ export async function generateMetadata({ params }) {
   });
 }
 
-async function Fiche({ params }) {
+async function Contribution({ params }) {
   const { _id, ...source } = await getContribution(params.slug);
   const relatedItems = await fetchRelatedItems({ _id }, params.slug);
   return (
@@ -37,4 +37,4 @@ const getContribution = async (slug: string) => {
   return contribution;
 };
 
-export default Fiche;
+export default Contribution;
diff --git a/packages/code-du-travail-frontend/src/modules/contributions/ContributionLayout.tsx b/packages/code-du-travail-frontend/src/modules/contributions/ContributionLayout.tsx
@@ -228,7 +228,7 @@ export function ContributionLayout({ relatedItems, contribution }: Props) {
                     | ElasticSearchContributionConventionnelle
                 }
                 titleLevel={2}
-              ></ContributionContent>
+              />
               {contribution.references.length && (
                 <Accordion label="Références">
                   <ListWithArrow

diff --git a/...frontend/__tests__/contributions.test.tsx → ...ibutions/__tests__/contributions.test.tsx b/...frontend/__tests__/contributions.test.tsx → ...ibutions/__tests__/contributions.test.tsx
@@ -1,7 +1,7 @@
 import { render } from "@testing-library/react";
 import React from "react";
 
-import PageContribution from "../pages/contribution/[slug]";
+import { ContributionLayout } from "../ContributionLayout";
 import { ElasticSearchContribution } from "@socialgouv/cdtn-types";
 
 const contribution = {
@@ -15,12 +15,13 @@ const contribution = {
   },
   title: "La période d’essai peut-elle être renouvelée ?",
   breadcrumbs: [],
+  slug: "slug",
 } as Partial<ElasticSearchContribution> as any;
 
 describe("<PageContribution />", () => {
   it("should render title with cc name in it", () => {
     const { getByRole } = render(
-      <PageContribution contribution={contribution} />
+      <ContributionLayout contribution={contribution} relatedItems={[]} />
     );
     const titreH1 = getByRole("heading", { level: 1 });
     expect(titreH1.textContent).toBe(
@@ -30,29 +31,11 @@ describe("<PageContribution />", () => {
   it("should render title with only question", () => {
     contribution.ccnShortTitle = "Ce short title fait plus de 15 caractères";
     const { getByRole } = render(
-      <PageContribution contribution={contribution} />
+      <ContributionLayout contribution={contribution} relatedItems={[]} />
     );
     const titreH1 = getByRole("heading", { level: 1 });
     expect(titreH1.textContent).toBe(
       "La période d’essai peut-elle être renouvelée ?"
     );
   });
-  it("should render title with linked content with no description", () => {
-    let contribution = {
-      source: "contributions",
-      linkedContent: [{ source: "", title: "My link", slug: "" }],
-      references: [],
-      idcc: "",
-      metas: {
-        title: "SEO Title",
-        description: "SEO Description",
-      },
-      title: "La période d’essai peut-elle être renouvelée ?",
-    } as any;
-    const { getByRole } = render(
-      <PageContribution contribution={contribution} />
-    );
-    const titreH3 = getByRole("heading", { level: 3 });
-    expect(titreH3.textContent).toBe("My link");
-  });
 });
diff --git a/...nd/src/modules/enterprise/EnterpriseAgreementSearch/__tests__/AgreementSelection.test.tsx b/...nd/src/modules/enterprise/EnterpriseAgreementSearch/__tests__/AgreementSelection.test.tsx
@@ -1,6 +1,6 @@
 import { render, RenderResult } from "@testing-library/react";
 import React from "react";
-import { EnterpriseAgreementSelection } from "../EnterpriseAgreementSelectionLink";
+import { EnterpriseAgreementSelectionLink } from "../EnterpriseAgreementSelectionLink";
 import { ui } from "./ui";
 import { sendEvent } from "../../../utils";
 import { UserAction } from "src/common";
@@ -51,7 +51,7 @@ describe("Trouver sa CC - recherche par nom d'entreprise CC", () => {
   let userAction: UserAction;
   it("Vérifier l'affichage de la selection", async () => {
     rendering = render(
-      <EnterpriseAgreementSelection enterprise={defaultEnterprise} />
+      <EnterpriseAgreementSelectionLink enterprise={defaultEnterprise} />
     );
     userAction = new UserAction();
     expect(
@@ -91,7 +91,7 @@ describe("Trouver sa CC - recherche par nom d'entreprise CC", () => {
 
   it("Vérifier l'affichage de la selection avec une CC sans slug", async () => {
     rendering = render(
-      <EnterpriseAgreementSelection
+      <EnterpriseAgreementSelectionLink
         enterprise={{
           ...defaultEnterprise,
           conventions: [
@@ -113,7 +113,7 @@ describe("Trouver sa CC - recherche par nom d'entreprise CC", () => {
 
   it("Vérifier l'affichage de la selection avec une CC sans url et contribution", async () => {
     rendering = render(
-      <EnterpriseAgreementSelection
+      <EnterpriseAgreementSelectionLink
         enterprise={{
           ...defaultEnterprise,
           conventions: [
@@ -136,7 +136,10 @@ describe("Trouver sa CC - recherche par nom d'entreprise CC", () => {
 
   it("Vérifier l'affichage de la selection en widgetMode", async () => {
     rendering = render(
-      <EnterpriseAgreementSelection enterprise={defaultEnterprise} widgetMode />
+      <EnterpriseAgreementSelectionLink
+        enterprise={defaultEnterprise}
+        widgetMode
+      />
     );
     expect(
       ui.enterpriseAgreementSelection.agreement.IDCC2216.link.query()

diff --git a/...modules/enterprise/EnterpriseAgreementSearch/__tests__/EnterpriseAgreementSearch.test.tsx b/...modules/enterprise/EnterpriseAgreementSearch/__tests__/EnterpriseAgreementSearch.test.tsx
@@ -112,7 +112,10 @@ describe("Trouver sa CC - recherche par nom d'entreprise CC", () => {
       expect(sendEvent).toHaveBeenLastCalledWith({
         action: "Trouver sa convention collective",
         category: "enterprise_select",
-        name: JSON.stringify(enterprise),
+        name: JSON.stringify({
+          label: enterprise.label,
+          siren: enterprise.siren,
+        }),
       });
       userAction.click(ui.enterpriseAgreementSearch.buttonPrevious.get());
       expect(sendEvent).toHaveBeenCalledTimes(4);