feat(DSFR): salaire brut / net #6260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolineBda
changed the title
carolineBda
temporarily deployed
to
review-auto
GitHub Actions
Inactive
carolineBda
temporarily deployed
to
review-auto
GitHub Actions
Inactive
carolineBda
temporarily deployed
to
review-auto
GitHub Actions
Inactive
carolineBda
changed the title
carolineBda
had a problem deploying
to
review-auto
GitHub Actions
Error
carolineBda
commented
Nov 5, 2024
| "have.text", | ||
| "Calculer le salaire brut/net" | ||
| ); | ||
| cy.findByRole("heading", { level: 1 }).click(); |
There was a problem hiding this comment.
c'est ça qui fixe le test 🤷♀️
carolineBda
commented
Nov 5, 2024
| @@ -82,7 +82,7 @@ const StyledDiv = styled.div` | |||
| height: 1.4rem; | |||
| margin: 0 ${spacings.tiny} 0 ${spacings.small}; | |||
| transition: transform ${theme.animations.transitionTiming} linear; | |||
| fill: ${theme.primary}; | |||
| fill: ${theme.colors.primary}; | |||
There was a problem hiding this comment.
j'ai fixé un warning qui apparaissait dans la console
carolineBda
had a problem deploying
to
review-auto
GitHub Actions
Error
carolineBda
had a problem deploying
to
review-auto
GitHub Actions
Error
carolineBda
temporarily deployed
to
review-auto
GitHub Actions
Inactive
carolineBda
changed the title
maxgfr
approved these changes
Nov 5, 2024
| const tool = await getTool(); | ||
| const relatedItems = await fetchRelatedItems( | ||
| { _id: tool._id }, | ||
| "simulateur-embauche" |
maxgfr
reviewed
Nov 5, 2024
Comment on lines
+19
to
+20
| const tool = await getTool(); | ||
| const relatedItems = await fetchRelatedItems( |
There was a problem hiding this comment.
c'est dommage qu'on fasse les deux calls en asynchrone. il faudra voir comment optimiser cette page en utilisant la logique statique de nextjs avec du cache.
car en soit, je pense pas que les info de l'outil et les related items changent tous les jours
ça pourrait drastiquement augmenter nos performances sur cette page
m-maillot
approved these changes
Nov 6, 2024
Viczei
approved these changes
Nov 7, 2024
carolineBda
had a problem deploying
to
review-auto
GitHub Actions
Error
carolineBda
temporarily deployed
to
review-auto
GitHub Actions
Inactive
carolineBda
temporarily deployed
to
review-auto
GitHub Actions
Inactive
|
🎉 Deployment for commit 83bcddb : IngressesDocker images
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: @Viczei
Fix #6197 https://github.com/orgs/SocialGouv/projects/142/views/1?pane=issue&itemId=85173296