Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat cerfa dates #3598

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Feat cerfa dates #3598

merged 2 commits into from
Dec 17, 2024

Conversation

pYassine
Copy link
Contributor

No description provided.

Copy link

🎉 Deployment for commit 6919207 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-69192077b33d707f197a8ad30bc00d0053f94ee9
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-69192077b33d707f197a8ad30bc00d0053f94ee9
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-69192077b33d707f197a8ad30bc00d0053f94ee9
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-69192077b33d707f197a8ad30bc00d0053f94ee9
Debug

@pYassine pYassine marked this pull request as ready for review December 17, 2024 15:11
@pYassine pYassine merged commit 0c1fc37 into master Dec 17, 2024
12 of 13 checks passed
@pYassine pYassine deleted the feat-cerfa-dates branch December 17, 2024 15:11
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.188.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 66.51%. Comparing base (5619783) to head (0f66c39).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...rs/admin-structures/admin-structures.controller.ts 42.85% 4 Missing ⚠️
.../auth/guards/structure-information-access.guard.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3598      +/-   ##
==========================================
- Coverage   66.64%   66.51%   -0.14%     
==========================================
  Files         909      910       +1     
  Lines       14870    14912      +42     
  Branches     2064     2071       +7     
==========================================
+ Hits         9910     9918       +8     
+ Misses       4787     4685     -102     
- Partials      173      309     +136     
Files with missing lines Coverage Δ
.../backend/src/auth/services/auth-checker.service.ts 100.00% <100.00%> (ø)
...t-password/userResetPasswordEmailSender.service.ts 100.00% <100.00%> (ø)
...ackend/src/structures/services/location.service.ts 66.66% <ø> (-8.34%) ⬇️
...d/src/users/controllers/users.public.controller.ts 93.54% <100.00%> (+0.44%) ⬆️
...rt-usagers/components/import/import.component.html 100.00% <ø> (ø)
...port-usagers/components/import/import.component.ts 38.09% <100.00%> (+0.74%) ⬆️
...-download-docs/manage-download-docs.component.html 100.00% <ø> (ø)
...ge-download-docs/manage-download-docs.component.ts 65.38% <100.00%> (+4.51%) ⬆️
...ossier/components/step-rdv/step-rdv.component.html 100.00% <ø> (ø)
.../auth/guards/structure-information-access.guard.ts 21.05% <0.00%> (ø)
... and 1 more

... and 65 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50d719d...0f66c39. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants