Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fix search of date birth #3604

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix(frontend): fix search of date birth #3604

merged 1 commit into from
Dec 19, 2024

Conversation

pYassine
Copy link
Contributor

No description provided.

@pYassine pYassine marked this pull request as ready for review December 19, 2024 19:47
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
22.9% Duplication on New Code (required ≤ 15%)

See analysis details on SonarQube Cloud

Copy link

Report too large to display inline

View full report↗︎

@pYassine pYassine merged commit 62f1510 into master Dec 19, 2024
13 of 14 checks passed
@pYassine pYassine deleted the fix-load-domifa branch December 19, 2024 19:52
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.188.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 58.34%. Comparing base (3998ca4) to head (730bf4b).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...lter/services/usagersSearchStringFilter.service.ts 16.66% 6 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (3998ca4) and HEAD (730bf4b). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3998ca4) HEAD (730bf4b)
2 1
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3604      +/-   ##
==========================================
- Coverage   66.49%   58.34%   -8.15%     
==========================================
  Files         912      379     -533     
  Lines       14942     6761    -8181     
  Branches     2070      820    -1250     
==========================================
- Hits         9936     3945    -5991     
+ Misses       4698     2649    -2049     
+ Partials      308      167     -141     
Files with missing lines Coverage Δ
...ntend/src/app/shared/store/setUsagerInformation.ts 100.00% <ø> (ø)
...lter/services/usagersSearchStringFilter.service.ts 56.00% <16.66%> (+1.83%) ⬆️

... and 533 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dedb85...730bf4b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants