Eric Kepes Submission #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I built this using .Net Core on a Mac. To make it a bit easier, I wrote some bash shell scripts to set things up and run the service:
The migration process deserves a little more discussion. The migration is run if the application is started with the command line parameter "migrate". This is in keeping in line with the principles of a 12-factor app, which I try to follow as much as makes sense.
None of the logins for SQL Server are secure - they are kept in plain text right in the repository. If this were a production app, I would not do it that way, but given there is no real risk, I left them there to facilitate easy running of the service by anyone reviewing it.
If you run the application and browser to the app url http://localhost:5000/swagger, you will be presented with a Swagger UI that you can use to explore the API. This is provided by NSwag.
There is no validation of users. Because it is not specified how to handle user accounts, I keep it simple and ignored the concept. Users are just email addresses.